Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
In-Reply-To: <20200829103637.1730050-1-yili@winhong.com>
References: <20200829103637.1730050-1-yili@winhong.com>
From:   Yi Li <yilikernel@gmail.com>
Date:   Sat, 29 Aug 2020 19:00:29 +0800
Message-ID: <CAJfdMYCLNzWVKZMgmzU5oDg+6yhZ3JMaBv7_CmM7MCgY7A9iPQ@mail.gmail.com>
Subject: Re: [PATCH] bnx2x: correct a mistake when show error code
To:     Yi Li <yili@winhong.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        kuba@kernel.org, davem@davemloft.net,
        GR-everest-linux-l2@marvell.com, skalluru@marvell.com,
        aelior@marvell.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

It is useless.
The original code just tell some error info. and don't  show errorcode

On 8/29/20, Yi Li <yili@winhong.com> wrote:
> use rc for error code.
>
> Signed-off-by: Yi Li <yili@winhong.com>
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> index 1426c691c7c4..0346771396ce 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x
> *bp, u32 shmem_base_path[],
>  	}
>
>  	if (rc)
> -		netdev_err(bp->dev,  "Warning: PHY was not initialized,"
> -				      " Port %d\n",
> -			 0);
> +		netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
> +			   rc);
>  	return rc;
>  }
>
> --
> 2.25.3
>
>
>
>