Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200829124356.18148-1-krzk@kernel.org>
In-Reply-To: <20200829124356.18148-1-krzk@kernel.org>
From:   Chanwoo Choi <chanwoo@kernel.org>
Date:   Sat, 29 Aug 2020 22:10:26 +0900
Message-ID: <CAGTfZH0o1-_mgpiLxnmhtV3-yrybr9uDDQAV_eE3oFEdd4nz8g@mail.gmail.com>
Subject: Re: [PATCH 1/4] extcon: max14577: Return error code of extcon_dev_allocate()
To:     Krzysztof Kozlowski <krzk@kernel.org>
Cc:     Chanwoo Choi <cw00.choi@samsung.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Aug 29, 2020 at 9:46 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> devm_extcon_dev_allocate() can fail of multiple reasons.  The call
> returns proper error code on failure so pass it instead of fixed ENOMEM.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>  drivers/extcon/extcon-max14577.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
> index cc47d626095c..ace523924e58 100644
> --- a/drivers/extcon/extcon-max14577.c
> +++ b/drivers/extcon/extcon-max14577.c
> @@ -713,7 +713,7 @@ static int max14577_muic_probe(struct platform_device *pdev)
>                                               max14577_extcon_cable);
>         if (IS_ERR(info->edev)) {
>                 dev_err(&pdev->dev, "failed to allocate memory for extcon\n");
> -               return -ENOMEM;
> +               return PTR_ERR(info->edev);
>         }
>
>         ret = devm_extcon_dev_register(&pdev->dev, info->edev);
> --
> 2.17.1
>

Applied them for patch1-4. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics