Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1877592pxa; Sat, 29 Aug 2020 06:30:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyLLcj5UlE6q79Oz6ISJ8KFq3Mx3DAYSpc0iannHD8QVbgf1Wl/EH2skThwrjk8Miwcc1xj X-Received: by 2002:aa7:c6ca:: with SMTP id b10mr3396224eds.269.1598707800444; Sat, 29 Aug 2020 06:30:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598707800; cv=none; d=google.com; s=arc-20160816; b=KI1Ep7h9Ux/N+62FuqYG1Y5QKkkNf/d+sF7Zj89NSQTayk1m11KvMuQXhVgVB8jzVf g7BCvByntljYjB8JjdLV1SQUPnc5Ad6gN2dfxILz45uXuroyi3buxK6rE7VH+TRH0256 EcbFlSq4bAXFDjEki6Aj/veMwKTgHsdfZHzSfWEXMf6/5Ov98BhhWWnnIAALAtEzt6/N 7YHJJDSjTBaGWDNgShgtsQrfxg3SimLmBDsNtXbUsHWsgN4Aeaicl41g7/J78yur8Hge 6y94ABgVJz6KXrEI6zhizAmC++kUuTHATsdckJP9lNJhPPJ9w0Kq8E2Ig4EEkIf/ucHi egEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=UaoRSWpCtl8QfpvpbkUB4Gp4h9nlPVcWno8Td3ncCmU=; b=sph4yq9wFRaJaIUjy1lS9uGpoU4lUQaIkl0RP5cs8Lk59fPYT4RXHTF4qL1r0qxpzF PJDTogR+YioIBjLakCApiR19as5R9h7g46kzKgsbSULdDtuSOdQRo7k3+2cbbfYGXvG2 sFhaux0wPOgLFSsT1yjTmclls5LTFdABT2SSo6QJ/WWtqUTg5Wo2jjhS7GRFTMejrQEv V/7aNUs26VjPIwb/g7Zh0r4IICNhtIxacEKmLzluBxm/J+cds/iYM60H5jl3GEz0r2Rk ksqGlOECYs1LGtqDnYo2oVYELS/OyhaJOQDDCNxSiSj0X0Pb7Alufb17xLYQzQNK/6ip mAyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bZcf9hlX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si1811839ejc.567.2020.08.29.06.29.38; Sat, 29 Aug 2020 06:30:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bZcf9hlX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728258AbgH2NWy (ORCPT + 99 others); Sat, 29 Aug 2020 09:22:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:56556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728187AbgH2NKe (ORCPT ); Sat, 29 Aug 2020 09:10:34 -0400 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B8D5204FD for ; Sat, 29 Aug 2020 13:10:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598706632; bh=JrW3phSyO7/tjND730C4AAWV/GZaE1G6sgDn0C6AGm0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=bZcf9hlXfjYogWKjUCIkT90Qz3fzpTOhcPETkI3diI2WYFVVQAr8bqva4D+sxztPe Pus1Xgxinv+kqBPWZDJPLFSG930DlP9EsZ9HVVAAfj3qXPZJzihbnxWAiFZjV0UUtg NMnShvXo+3eU27PPvCcr1SjBxAuNG8GpcoqzEUVk= Received: by mail-lj1-f178.google.com with SMTP id v12so1811866ljc.10 for ; Sat, 29 Aug 2020 06:10:32 -0700 (PDT) X-Gm-Message-State: AOAM5311sZDpo/JgtTkAWyxWYQOOc5KgP7mIJBU0Zbu0zkwPlHirke+u 51txKPM6F59fRVFfTJ7ibUZX6j6WUmVjP9KCnQ8= X-Received: by 2002:a2e:320c:: with SMTP id y12mr1460478ljy.399.1598706630590; Sat, 29 Aug 2020 06:10:30 -0700 (PDT) MIME-Version: 1.0 References: <20200828151337.6748-1-krzk@kernel.org> In-Reply-To: <20200828151337.6748-1-krzk@kernel.org> From: Chanwoo Choi Date: Sat, 29 Aug 2020 22:09:53 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] extcon: palmas: Simplify with dev_err_probe() To: Krzysztof Kozlowski Cc: MyungJoo Ham , Chanwoo Choi , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 29, 2020 at 12:15 AM Krzysztof Kozlowski wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/extcon/extcon-palmas.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c > index e8e9eebe6b1d..a2852bcc5f0d 100644 > --- a/drivers/extcon/extcon-palmas.c > +++ b/drivers/extcon/extcon-palmas.c > @@ -205,21 +205,15 @@ static int palmas_usb_probe(struct platform_device *pdev) > > palmas_usb->id_gpiod = devm_gpiod_get_optional(&pdev->dev, "id", > GPIOD_IN); > - if (PTR_ERR(palmas_usb->id_gpiod) == -EPROBE_DEFER) { > - return -EPROBE_DEFER; > - } else if (IS_ERR(palmas_usb->id_gpiod)) { > - dev_err(&pdev->dev, "failed to get id gpio\n"); > - return PTR_ERR(palmas_usb->id_gpiod); > - } > + if (IS_ERR(palmas_usb->id_gpiod)) > + return dev_err_probe(&pdev->dev, PTR_ERR(palmas_usb->id_gpiod), > + "failed to get id gpio\n"); > > palmas_usb->vbus_gpiod = devm_gpiod_get_optional(&pdev->dev, "vbus", > GPIOD_IN); > - if (PTR_ERR(palmas_usb->vbus_gpiod) == -EPROBE_DEFER) { > - return -EPROBE_DEFER; > - } else if (IS_ERR(palmas_usb->vbus_gpiod)) { > - dev_err(&pdev->dev, "failed to get vbus gpio\n"); > - return PTR_ERR(palmas_usb->vbus_gpiod); > - } > + if (IS_ERR(palmas_usb->vbus_gpiod)) > + return dev_err_probe(&pdev->dev, PTR_ERR(palmas_usb->vbus_gpiod), > + "failed to get id gpio\n"); > > if (palmas_usb->enable_id_detection && palmas_usb->id_gpiod) { > palmas_usb->enable_id_detection = false; > -- > 2.17.1 > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics