Received: by 2002:a05:6a10:6006:0:0:0:0 with SMTP id w6csp1913277pxa; Sat, 29 Aug 2020 07:35:24 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvKHCFCCu308vg99/BLIvvIbwy3IavQZtzI1O/XOd5iSHfZf9xsCmB7azFIyVMNbflDyU7 X-Received: by 2002:a17:906:e0c2:: with SMTP id gl2mr3750761ejb.160.1598711723823; Sat, 29 Aug 2020 07:35:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598711723; cv=none; d=google.com; s=arc-20160816; b=nndnRD/XuQTYZ51mQ07dO0R06zYclUj9umg/mDZ44yPHzvdoBXQyPIGAV3CufxpR2S kCzIY4nwpmxs34949gxcaSND4ESMmfj/RiCUKM6ELc7+Y0Ogk0iNeLXtXPwdXiatQfNx E2qdT6IRSD2sJTTxh4YFy5IkFqWsuklq2etRFgZoh66nBeyydQ+zxERo+/9l1+iNwOt+ CsOO5YHC299AYNz8t4liPsFjiLla5tObFm4Mo2rc8dRLTE2aqcHoh3JSzaIJUnkjT3Sd aY0G5qcZS6h1sBVyw99S4aBaO7vql8fEknjkG7ACE6fxknbu+27aCsCb6pY+wczkN/V6 75CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=XJl+h2g8wNM8Nwnv6/nuRkC/VnUuDXl3sJpZ9c9XY2A=; b=ARGMQ0yNnSRW99Ey6Jmi3ive8lSU4lM/Wd8Dv9meLBOL+G0GtLzXpJ+c1VdLTWZAXz Xl0aqJKxoc55qTbaO1gT4ufwx0cr645bxBrtGBnv3PW9lwMOdImXnCpWRP1y/W9SMW86 rIxlz9GrJWMSFMWXJaRp7ZlR39ZKosC8Ob3aBSd0p9XIpL/tJF6nZ/RKmZfSZ9vYfnBg lXbskLbRpuJPaE5nVMgaBB+mW5caJSyE3s/RV5lnJbNL4QaNQNJPBBGRjWBclY+/opCs 5PkrtHqQZt6NuhR/BZBl346K0Sj4xf5iCO/efI2DmEPu9MQoK3Pntpssjx6OlOEFU98h tvvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=LYRa4gG0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r25si1554137eds.157.2020.08.29.07.35.00; Sat, 29 Aug 2020 07:35:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=LYRa4gG0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728196AbgH2Oc1 (ORCPT + 99 others); Sat, 29 Aug 2020 10:32:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728082AbgH2Oc0 (ORCPT ); Sat, 29 Aug 2020 10:32:26 -0400 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F7D0C061236 for ; Sat, 29 Aug 2020 07:32:26 -0700 (PDT) Received: by mail-pj1-x1032.google.com with SMTP id q93so791405pjq.0 for ; Sat, 29 Aug 2020 07:32:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XJl+h2g8wNM8Nwnv6/nuRkC/VnUuDXl3sJpZ9c9XY2A=; b=LYRa4gG08W3F40Jbv5mfiUBNp+SW2M7MNBcDNl4NQpgW2Fs6qQiybElsYytIID2jer y7bZD2wsTC6XgTltJiHtiavmipiLYyGlboFJlHY9mSo/d5RwGawqUh6RjWapqJcz6guS FHlrykCs4hl6gTfOaXxDe5HFxKXxy6JX2YULYenpbSeuonCml9jqBnh1TCzTxjMowtTI zdmp04ea5JqHnKqv/DBNW8+TDQ4ROqyXOYzQjlvNVs16yZV4puVMp0ZN3wZF3lAEwIdy 6IwPSIvt1zjwW79JExIMkTugxhIiCA+2a31dODN34N8Gfe+AAP8X6pnK5LgLCka9UF1H 6jOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XJl+h2g8wNM8Nwnv6/nuRkC/VnUuDXl3sJpZ9c9XY2A=; b=jw2/QSkApNXexRKHfCat2o1e9gnUMCGMQp/f2RLOEte47Z+C8lAJajzxZvH+GG4xGp yk8Cpq1KEAvjKJaBntwD7HfK246wQoTEjUdSgLN3GM5usMKX9OGZD5g1rxCdUyrz5bXf cwZlvSMEeBBUo+5q7Z8kPjJoN1mQxY/QHG/QCcX4kDKBxdbw+Eto3AEcQI6jT00DzVuv 2fWOF/0XnX5x7NdZLZad8Y64tW0jjMxoTQXNI/OKw7nO1RmHlXTqc4H4oGNcpb/QNBTK MdXzr0lSHrMe9EM1K8TvdS7rzJRtFxDPZJJ86rKOLi3IqwA3LczZRZEyvDAJY3uCQgqX exJA== X-Gm-Message-State: AOAM5324w/Av7mf2Vavll9R0NLD8z/d4swgS8FKAscEbrwC11uLtz/eV eU5IwqPjiynQjkzkqlzSWu1OOEGwepVpXY50 X-Received: by 2002:a17:90a:8418:: with SMTP id j24mr3336598pjn.212.1598711543446; Sat, 29 Aug 2020 07:32:23 -0700 (PDT) Received: from [192.168.1.187] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id t10sm2609212pgp.15.2020.08.29.07.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Aug 2020 07:32:22 -0700 (PDT) Subject: Re: [PATCH] block: bio: Trim bio to sensible size in bio_trim() To: Miaohe Lin Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200829093733.45833-1-linmiaohe@huawei.com> From: Jens Axboe Message-ID: <19788ba3-31bb-c0fd-0577-842dca519f8c@kernel.dk> Date: Sat, 29 Aug 2020 08:32:21 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200829093733.45833-1-linmiaohe@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/20 3:37 AM, Miaohe Lin wrote: > Trim bio to sensible size in bio_trim() or something bad may happen. This really needs a LOT more detail. What is "something bad"? How does this condition trigger to begin with? -- Jens Axboe