Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 3/3] bio: convert get_user_pages_fast() -->
 pin_user_pages_fast()
To:     Christoph Hellwig <hch@infradead.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Ilya Dryomov <idryomov@gmail.com>,
        Jens Axboe <axboe@kernel.dk>, <linux-xfs@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-block@vger.kernel.org>,
        <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
References: <20200829080853.20337-1-jhubbard@nvidia.com>
 <20200829080853.20337-4-jhubbard@nvidia.com>
 <20200829150223.GC12470@infradead.org>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <95880e98-f4d6-add1-db96-ae349064d3c6@nvidia.com>
Date:   Sat, 29 Aug 2020 15:08:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200829150223.GC12470@infradead.org>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 8/29/20 8:02 AM, Christoph Hellwig wrote:
>> -	size = iov_iter_get_pages(iter, pages, LONG_MAX, nr_pages, &offset);
>> +	size = iov_iter_pin_user_pages(iter, pages, LONG_MAX, nr_pages, &offset);
> 
> This is really a comment to the previous patch, but I only spotted it
> here:  I think the right name is iov_iter_pin_pages, as bvec, kvec and
> pipe aren't usually user pages.  Same as iov_iter_get_pages vs
> get_user_pages.  Same for the _alloc variant.
> 

Yes, it is clearly misnamed now! Will fix.

>> + * here on.  It will run one unpin_user_page() against each page
>> + * and will run one bio_put() against the BIO.
> 
> Nit: the ant and the will still fit on the previous line.
> 

Sorry about that, *usually* my text editor does the Right Thing for
those, I must have interfered with the natural flow of things. :)


thanks,
-- 
John Hubbard
NVIDIA