Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] USB: integrate macro definitions into include/linux/usb.h
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200825154421.5463-1-yanfei.xu@windriver.com>
 <20200828074826.GA962117@kroah.com>
From:   "Xu, Yanfei" <yanfei.xu@windriver.com>
Message-ID: <97eb35be-9550-ea50-da72-5ce10757379b@windriver.com>
Date:   Sun, 30 Aug 2020 13:23:24 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
In-Reply-To: <20200828074826.GA962117@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from 255.255.255.255 (255.255.255.255) by HK2PR02CA0187.apcprd02.prod.outlook.com (2603:1096:201:21::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Sun, 30 Aug 2020 05:23:30 +0000
X-Originating-IP: [60.247.85.82]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: cb29fd4e-5a64-44f6-80a7-08d84ca4d5c3
X-MS-TrafficTypeDiagnostic: BYAPR11MB2725:
X-Microsoft-Antispam-PRVS: <BYAPR11MB27251D2D08A750AB7BEBC96BE4500@BYAPR11MB2725.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:10000;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: rqcMaSt2Vr7t450N5SCcRC4hfVGa6yViEuwsu3ha2SgyYPyvHqphCFIMg28O6vU7MXPSG4zy+xALRTBYxq3D9lvMUs5NZUbmKQ81Zer8OSfYyscYJz/9lT+W3t0o7uNLgYby9b+be8RDhYqPyhVFbDJTMgTdJfRRGvTrlLwH9t9+f0TrvUKvn25ZjPb3j2Anyc02CJ9liAgdxHZcIwyZsg+5aN4D9VwEGsgAQfR4Ehwz4UJTdOwiiYzArpSVSdIM4eDtSgrXbkex4SeBH7vsvj+VeFXMtamg6rETpHU5/rBzHj0GT8WvVcaAnbf4TUICcME9ET52aFY+ep7e8mME/MT8PON1qlKKC3qQSrhZ+6KyzuF0pOJnfAtvafNTWCIY
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR11MB4241.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(39830400003)(346002)(376002)(396003)(136003)(956004)(31696002)(2906002)(36756003)(86362001)(316002)(2616005)(8676002)(478600001)(6916009)(4744005)(8936002)(6486002)(66476007)(66556008)(16576012)(31686004)(53546011)(5660300002)(26005)(186003)(4326008)(52116002)(83380400001)(6666004)(66946007)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: e0y3q/iWhCkBZG1ruXiRE1dYdYPkA6k4VVa3sYKgd1Tlobu8muuu/ql+sQaT+u67K35ETZlxHu+ysWAYLZZb+DXJMEVflRuyb7buwZMjqDepxAFdZuni+jIvouHPO+HHoxvN4HHgT+suM4/EYuZIIjMZ3P2vkCgNApJpydeeWXIDPMqLWDCGZMLrGaf7jBho5uTrO39jUNugIaXPJRypIbNTbU8cKvl3mBjqaFhOrUvgnTbP4vlYyAL29+5WgYEmsV5RGenNORwr7oOidraDhxfG3GuKOuzRta7SXDjcLRT0UimjISdCMROpHr0MiZx74rWFU1hLhmTJp6LP+Zj9Pd+V4Pufe1f4/cxOe5q0dXacIdYJuL/ocLpD7QwUcxtl9/YshfUNf6AK2Vs3rqk2DUupBRVezMwEdK756itD55t1OxOjXtG6eRgPEsA/ESbn5vNbp7P1pYPPK7xAi1mf1/TgiFiwfgldh7ST05WyALZq0Wq351sTiqM2ivlD8u0eGVZs8zaPYD13xTcnvmv9EFo9rWKWYW0TSB5G6IGDDifRHHa62MoSE//EGqLvlcW0+m7d9WJt5rXDoIVFi6yVUaOZoFoHkuyWDmnYRldhz+YjsZv2dTnEl+GmD5hV+T8avkz82v7Tk5j+aGUUfxdryw==
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb29fd4e-5a64-44f6-80a7-08d84ca4d5c3
X-MS-Exchange-CrossTenant-AuthSource: BY5PR11MB4241.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2020 05:23:31.9890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ygoU9g45mJojPnI46D6arpBRfkkl4h7Hd63lLpmZ95gIIMu5C1BxvogjU13sxad+qS5PRwFxga0IS43rXTvS0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2725
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

I just think it is a clear up to make these macros get togather
which have the samilar attributes. That's why :)

Thanks,
Yanfei

On 8/28/20 3:48 PM, Greg KH wrote:
> On Tue, Aug 25, 2020 at 11:44:21PM +0800, yanfei.xu@windriver.com wrote:
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> include/linux/usb.h also contains 'Hard limit' and 'Arbitrary limit'
>> macro definitions in it, hence we can integrate these from config.c
>> into include/linux/usb.h
> 
> Why?  No one uses these values outside of this .c file, so why put a
> value in a global .h file?
> 
> Who else wants to use these values?  If something else needs it, then
> sure, it could be moved, but until then, there's nothing wrong with the
> existing code as-is from what I can tell.
> 
> thanks,
> 
> greg k-h
>