Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [EXT] [PATCH] bnx2x: correct a mistake when show error code
To:     Yi Li <yili@winhong.com>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>
CC:     <yilikernel@gmail.com>, <kuba@kernel.org>, <davem@davemloft.net>,
        GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>,
        "Sudarsana Reddy Kalluru" <skalluru@marvell.com>,
        Ariel Elior <aelior@marvell.com>
References: <20200829103637.1730050-1-yili@winhong.com>
From:   Igor Russkikh <irusskikh@marvell.com>
Message-ID: <3f42d243-dd35-f787-f123-9a2fcb5a9bc8@marvell.com>
Date:   Sun, 30 Aug 2020 10:58:01 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101
 Thunderbird/80.0
MIME-Version: 1.0
In-Reply-To: <20200829103637.1730050-1-yili@winhong.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c 
> b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> index 1426c691c7c4..0346771396ce 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
> @@ -13562,9 +13560,8 @@ static int bnx2x_ext_phy_common_init(struct bnx2x 
> *bp, u32 shmem_base_path[],
>  	}
> 
>  	if (rc)
> -		netdev_err(bp->dev,  "Warning: PHY was not initialized,"
> -				      " Port %d\n",
> -			 0);
> +		netdev_err(bp->dev, "Warning: PHY was not initialized, Port %d\n",
> +			   rc);
>  	return rc;

Hi Yi,

Thanks, but if you want to report rc in this trace - then state "rc = %d"
explicitly in the string. Because now its "Port %d" but you put error code in
there...

Thanks,
   Igor