Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965172AbWEYN4Q (ORCPT ); Thu, 25 May 2006 09:56:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965170AbWEYN4Q (ORCPT ); Thu, 25 May 2006 09:56:16 -0400 Received: from amsfep17-int.chello.nl ([213.46.243.15]:64478 "EHLO amsfep11-int.chello.nl") by vger.kernel.org with ESMTP id S965172AbWEYN4H (ORCPT ); Thu, 25 May 2006 09:56:07 -0400 From: Peter Zijlstra To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Hugh Dickins , Andrew Morton , David Howells , Peter Zijlstra , Christoph Lameter , Martin Bligh , Nick Piggin , Linus Torvalds Date: Thu, 25 May 2006 15:56:05 +0200 Message-Id: <20060525135605.20941.4410.sendpatchset@lappy> In-Reply-To: <20060525135534.20941.91650.sendpatchset@lappy> References: <20060525135534.20941.91650.sendpatchset@lappy> Subject: [PATCH 2/3] mm: balance dirty pages Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2804 Lines: 85 From: Peter Zijlstra Now that we can detect writers of shared mappings, throttle them. Avoids OOM by surprise. Changes -v2: - small helper function (Andrew Morton) Signed-off-by: Peter Zijlstra include/linux/writeback.h | 1 + mm/memory.c | 5 +++-- mm/page-writeback.c | 10 ++++++++++ 3 files changed, 14 insertions(+), 2 deletions(-) Index: linux-2.6/mm/memory.c =================================================================== --- linux-2.6.orig/mm/memory.c 2006-05-25 15:46:31.000000000 +0200 +++ linux-2.6/mm/memory.c 2006-05-25 15:46:55.000000000 +0200 @@ -49,6 +49,7 @@ #include #include #include +#include #include #include @@ -1558,7 +1559,7 @@ gotten: unlock: pte_unmap_unlock(page_table, ptl); if (dirty_page) { - set_page_dirty(dirty_page); + set_page_dirty_balance(dirty_page); put_page(dirty_page); } return ret; @@ -2205,7 +2206,7 @@ retry: unlock: pte_unmap_unlock(page_table, ptl); if (dirty_page) { - set_page_dirty(dirty_page); + set_page_dirty_balance(dirty_page); put_page(dirty_page); } return ret; Index: linux-2.6/include/linux/writeback.h =================================================================== --- linux-2.6.orig/include/linux/writeback.h 2006-05-25 15:07:44.000000000 +0200 +++ linux-2.6/include/linux/writeback.h 2006-05-25 15:46:55.000000000 +0200 @@ -114,6 +114,7 @@ int sync_page_range(struct inode *inode, loff_t pos, loff_t count); int sync_page_range_nolock(struct inode *inode, struct address_space *mapping, loff_t pos, loff_t count); +void set_page_dirty_balance(struct page *page); /* pdflush.c */ extern int nr_pdflush_threads; /* Global so it can be exported to sysctl Index: linux-2.6/mm/page-writeback.c =================================================================== --- linux-2.6.orig/mm/page-writeback.c 2006-05-25 15:46:08.000000000 +0200 +++ linux-2.6/mm/page-writeback.c 2006-05-25 15:46:55.000000000 +0200 @@ -255,6 +255,16 @@ static void balance_dirty_pages(struct a pdflush_operation(background_writeout, 0); } +void set_page_dirty_balance(struct page *page) +{ + if (set_page_dirty(page)) { + struct address_space *mapping = page_mapping(page); + + if (mapping) + balance_dirty_pages_ratelimited(mapping); + } +} + /** * balance_dirty_pages_ratelimited_nr - balance dirty memory state * @mapping: address_space which was dirtied - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/