Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= 
        <naoya.horiguchi@nec.com>
To:     Qian Cai <cai@lca.pw>, Muchun Song <songmuchun@bytedance.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm/memory-failure: Fix return wrong value when isolate
 page fail
Thread-Topic: [PATCH] mm/memory-failure: Fix return wrong value when isolate
 page fail
Thread-Index: AQHWfqVM3JSCQxmTuEa2NoqeFTKL/KlRDpsAgAAtigA=
Date:   Sun, 30 Aug 2020 22:27:18 +0000
Message-ID: <20200830222718.GA23542@hori.linux.bs1.fc.nec.co.jp>
References: <20200830081053.64981-1-songmuchun@bytedance.com>
 <20200830194417.GA4039@lca.pw>
In-Reply-To: <20200830194417.GA4039@lca.pw>
Accept-Language: ja-JP, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-2022-jp"
Content-ID: <77168D14E0092B48913FDB3A9F8F4D09@jpnprd01.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ab921a3c-9930-4b46-1488-08d84d33db29
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Aug 2020 22:27:18.8088
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZuypFXZuNsTCpOJEQ+9LUsleakTADHXbMj16DcprUHizB6VHotUi9+rTrWh69fe2xUJarZspDqwbtADtveonhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY2PR01MB3771
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 30, 2020 at 03:44:18PM -0400, Qian Cai wrote:
> On Sun, Aug 30, 2020 at 04:10:53PM +0800, Muchun Song wrote:
> > When we isolate page fail, we should not return 0, because we do not
> > set page HWPoison on any page.
> >=20
> > Signed-off-by: Muchun Song <songmuchun@bytedance.com>
>=20
> This seems solve the problem for me that madvise(MADV_SOFT_OFFLINE) will =
run
> into ENOMEM eventually:
>=20
> https://lore.kernel.org/lkml/20200811220643.GB39857@lca.pw/
>=20
> Reviewed-by: Qian Cai <cai@lca.pw>

Thank you very much, both of you!

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

> > ---
> >  mm/memory-failure.c | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> > index 696505f56910..4eb3c42ffe35 100644
> > --- a/mm/memory-failure.c
> > +++ b/mm/memory-failure.c
> > @@ -1850,6 +1850,7 @@ static int __soft_offline_page(struct page *page)
> >  	} else {
> >  		pr_info("soft offline: %#lx: %s isolation failed: %d, page count %d,=
 type %lx (%pGp)\n",
> >  			pfn, msg_page[huge], ret, page_count(page), page->flags, &page->fla=
gs);
> > +		ret =3D -EBUSY;
> >  	}
> >  	return ret;
> >  }
> > --=20
> > 2.11.0
> >=20
> >=20
> =