Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Aug 2020 09:19:07 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Joe Perches <joe@perches.com>
Cc:     Martin Kepplinger <martin.kepplinger@puri.sm>, robh@kernel.org,
        kernel@puri.sm, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, mchehab@kernel.org,
        Anson.Huang@nxp.com, agx@sigxcpu.org, angus@akkea.ca,
        broonie@kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/3] MAINTAINERS: Add Purism Librem 5 section to the
 list
Message-ID: <20200831011906.GB4488@dragon>
References: <20200821121755.24599-1-martin.kepplinger@puri.sm>
 <20200821121755.24599-2-martin.kepplinger@puri.sm>
 <20200830131459.GL32096@dragon>
 <1d7c6ef2794bedca7e3164e5435f46864eacddfa.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1d7c6ef2794bedca7e3164e5435f46864eacddfa.camel@perches.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Aug 30, 2020 at 08:32:01AM -0700, Joe Perches wrote:
> On Sun, 2020-08-30 at 21:15 +0800, Shawn Guo wrote:
> > On Fri, Aug 21, 2020 at 02:17:54PM +0200, Martin Kepplinger wrote:
> > > Add development information for the devicetree files for hardware
> > > by Purism SPC.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > 
> > I decided to drop this patch from my queue, as I took the suggestion
> > from Joe and sent a patch to have get_maintainer report email address
> > in the dts file.
> 
> It's OK to find maintainers in files, but what about the
> B: bug reporting and T: source code repository location lines,
> 
> Those seem useful.

Hmm, I doubt they are practically useful for just a number of dts files.
They are more used for out-of-tree Librem5 kernel drivers, I guess.

Shawn

> 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > > @@ -14061,6 +14061,13 @@ T:	git git://linuxtv.org/media_tree.git
> > >  F:	Documentation/admin-guide/media/pulse8-cec.rst
> > >  F:	drivers/media/cec/usb/pulse8/
> > >  
> > > +PURISM LIBREM 5
> > > +M:	Purism Kernel Team <kernel@puri.sm>
> 
> People feel like their mails go into a void when no
> responses happen after sending to nameless addresses.
> 
> It's better to have a named individual as a maintainer
> rather than an unspecified exploder address.
> 
> It's OK to have both, but just the exploder doesn't
> really have that much value as it's faceless.
> 
> > > +S:	Supported
> > > +B:	https://source.puri.sm/Librem5/linux-next/issues
> > > +T:	https://source.puri.sm/Librem5/linux-next
> 
> This T: line should be something else.
> 
> Perhaps
> W;	https://source.puri.sm/Librem5/linux-next
> T:	git https://source.puri.sm/Librem5/linux-next.git
> 
> > > +F:	arch/arm64/boot/dts/freescale/imx8mq-librem5*
> 
>