Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp763968pxk; Sun, 30 Aug 2020 23:24:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQI5Bfv3hlvi5zdmyNGJdZQQcmMxox3y0DZHpi4i/M8eyY5+bpm+dbfLqlF8uGvtwYDL45 X-Received: by 2002:a17:906:22cc:: with SMTP id q12mr10507864eja.78.1598855046509; Sun, 30 Aug 2020 23:24:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598855046; cv=none; d=google.com; s=arc-20160816; b=bm/ymkxmhgil0y3em1OC8a6kNE7O4LR3tSQ928ItGPQ7XGK5ATJ7tK7v2XCKPExkkX NrwSYzvj65D+iiTwlRleBzwwmieuY4JXtXrR/yPK3dNY24XVN18QRD4n8RmyXv5fhy0J CFw5hNFs+46v6ZRkx0fLn23eBoKAazQbErqf7e/6jL3aFfxWU1QKBw68tqSF5dIELBfH xZKI4G3J2lqtdPGg033j6paaxd6c/OLKOi4l1Oh+DfLWdW3qAMsnDonAAn8H9JuxObkR 3ZJ8kUB4P77Zj+V30Y8VD4qUnvlXptR84mxys70rvynnmGh4W68lKcKIeme7bdQyK9zX Bs0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=S5s+mD32nvqAgjLhv0luTWe/LakS2GEUrsEXnUwOCKE=; b=gF7mDPOd0u5lFofngC291hUl61BlHQXfuze9+EbdMicHeriey4g8kg2KziOEIgQC7Q dKRvr2uKYns5N1NfNO6jimd1Pm4f5t+WoCl4b/PaXZrsc3DR03x5ZB/JY1GwyBwsu/Fv 4PmH25lJxbm14BeeT4kBUszAD71f1LtcvmpXW10rtIfOAFVHM92LEOd2q+nn2o3tsf0g FhfykZnOB/GD9oqznBNW1lrlssAbh7/l/lDEUxBdYQRgddH9zGHOxhjxasXxUTXPtA0E yeEkC5lkI6eshBzWMHG17N5Lh6nwUeos3L4rro+9G5txJaxIGQiFqMx0oRb01tIsAznA Qelg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r11si2614656ejs.214.2020.08.30.23.23.44; Sun, 30 Aug 2020 23:24:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726564AbgHaGW6 (ORCPT + 99 others); Mon, 31 Aug 2020 02:22:58 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:10351 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725829AbgHaGW6 (ORCPT ); Mon, 31 Aug 2020 02:22:58 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 0452E2CF838EF92E9A46; Mon, 31 Aug 2020 14:22:55 +0800 (CST) Received: from [10.136.114.67] (10.136.114.67) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Mon, 31 Aug 2020 14:22:53 +0800 Subject: Re: [f2fs-dev] [PATCH] f2fs: prevent compressed file from being disabled after releasing cblocks To: Daeho Jeong , , , CC: Daeho Jeong References: <20200828054629.583577-1-daeho43@gmail.com> From: Chao Yu Message-ID: Date: Mon, 31 Aug 2020 14:22:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200828054629.583577-1-daeho43@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.136.114.67] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/8/28 13:46, Daeho Jeong wrote: > From: Daeho Jeong > > After releasing cblocks, the compressed file can be accidentally > disabled in compression mode, since it has zero cblocks. As we are > using IMMUTABLE flag to present released cblocks state, we can add > IMMUTABLE state check when considering the compressed file disabling. > > Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks,