Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Aug 2020 09:00:39 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-2?Q?Kamil_Doma=F1ski?= <kamil@domanski.co>
cc:     linux-kernel@vger.kernel.org,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Nestor Lopez Casado <nlopezcasad@logitech.com>,
        =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@archlinux.org>
Subject: Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533
 headset
In-Reply-To: <20200704004745.383271-1-kamil@domanski.co>
Message-ID: <nycvar.YFH.7.76.2008310859340.27422@cbobk.fhfr.pm>
References: <20200704004745.383271-1-kamil@domanski.co>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 4 Jul 2020, Kamil Doma?ski wrote:

> Changelog:
>   v2:
>   - changed charging status parsing to account for invalid states
>   v3:
>   - rebased against Linux v5.7
>   - changed variable naming in hidpp20_adc_map_status_voltage
>     to camel case
>   - corrected comment styling in hidpp_battery_get_property
>   - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage
>     to avoid using `long` type
>   - added bit flag definitions in hidpp20_adc_map_status_voltage
> 
> Signed-off-by: Kamil Doma?ski <kamil@domanski.co>

Hi,

I've finally made it to this patch (sorry for the delay), and it looks 
good to me in general (no major concerns with the polling either).

Could you please send me the proper changelog that should go to the 
commitlog though (it's definitely not this 'Changes sice vX ...').

Thanks,

-- 
Jiri Kosina
SUSE Labs