Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: c836ObG9SCR551eSOm/x+vng0TtKsbm8Sc3nNgx7BjJPHuIzzQuLEy/GZf/anidQzrFbCeQzQq
 qpKzZO1MffTg==
IronPort-SDR: +mGfJ4fN8GdX+b3galXYZm21+cuocKgUviGrYgLujy61A368eUKMv9P3+Btyp5No5MHi7pc9LD
 8t+h/Pxhldig==
Subject: Re: [PATCH 5/6] perf record: Add 'snapshot' control command
To:     Andi Kleen <ak@linux.intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org
References: <20200829105015.10800-1-adrian.hunter@intel.com>
 <20200829105015.10800-6-adrian.hunter@intel.com>
 <20200831062332.GW1509399@tassilo.jf.intel.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <64a87689-8ce9-c54a-98fd-b6ad7fd3aa92@intel.com>
Date:   Mon, 31 Aug 2020 10:03:40 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200831062332.GW1509399@tassilo.jf.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 31/08/20 9:23 am, Andi Kleen wrote:
> On Sat, Aug 29, 2020 at 01:50:14PM +0300, Adrian Hunter wrote:
>> Add 'snapshot' control command to create an AUX area tracing snapshot the
>> same as if sending SIGUSR2. The advantage of the FIFO is that access is
>> governed by access to the FIFO.
> 
> How about the --switch-output SIGUSR2 switch? Could that be handled too?

Presumably, but I have never used --switch-out because Intel PT does not yet
support it (it is on the list of things to do).  Perhaps someone more
familiar with it can add that :-)

> 
> Other than that it looks great. Thanks.
> 
> -Andi
>