Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030252AbWEYQ16 (ORCPT ); Thu, 25 May 2006 12:27:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030251AbWEYQ16 (ORCPT ); Thu, 25 May 2006 12:27:58 -0400 Received: from omx2-ext.sgi.com ([192.48.171.19]:44996 "EHLO omx2.sgi.com") by vger.kernel.org with ESMTP id S1030250AbWEYQ15 (ORCPT ); Thu, 25 May 2006 12:27:57 -0400 Date: Thu, 25 May 2006 09:27:31 -0700 (PDT) From: Christoph Lameter To: Peter Zijlstra cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Andrew Morton , David Howells , Christoph Lameter , Martin Bligh , Nick Piggin , Linus Torvalds Subject: Re: [PATCH 1/3] mm: tracking shared dirty pages In-Reply-To: <20060525135555.20941.36612.sendpatchset@lappy> Message-ID: References: <20060525135534.20941.91650.sendpatchset@lappy> <20060525135555.20941.36612.sendpatchset@lappy> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 698 Lines: 15 On Thu, 25 May 2006, Peter Zijlstra wrote: > - rebased on top of David Howells' page_mkwrite() patch. I am a bit confused about the need for Davids patch. set_page_dirty() is already a notification that a page is to be dirtied. Why do we need it twice? set_page_dirty could return an error code and the file system can use the set_page_dirty() hook to get its notification. What we would need to do is to make sure that set_page_dirty can sleep. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/