Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1598851448-5493-1-git-send-email-amit.pundir@linaro.org> <CAMi1Hd3n2rfr+k09L8WO1S1Tn1s3xJencmr1q3a6e-FOgXr5Qg@mail.gmail.com>
In-Reply-To: <CAMi1Hd3n2rfr+k09L8WO1S1Tn1s3xJencmr1q3a6e-FOgXr5Qg@mail.gmail.com>
From:   Konrad Dybcio <konradybcio@gmail.com>
Date:   Mon, 31 Aug 2020 09:57:39 +0200
Message-ID: <CAMS8qEXcANkb-HoTk8zrXQEzkQO4cnFw4hj5tMp82UEVKd+eHQ@mail.gmail.com>
Subject: Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)
To:     Amit Pundir <amit.pundir@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        John Stultz <john.stultz@linaro.org>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        dt <devicetree@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Hi Konrad,
>
> I couldn't find answer to your question around missing
> (regulatorname)-supply properties. Need help in figuring out that
> part.

When the phone boots up and RPM(H) kicks in, you should see regulators
probing like "s1 supplied by foo". Without the *-supply stuff, you
will likely get "supplied by regulator-dummy". This happens here [1]
and to my knowledge it is the "eletrical wiring" for Linux, as in it
makes Linux aware of which regulators are connected electrically to
the same supply (so that kernel knows when the supply is on and what
voltage it's at). For qcom platforms, this is common per-pmic (afaik,
please check if you are able to!), so you can likely just copy-paste
that part from msm8998-mtp.dtsi, which also uses pm(i)8998.

Konrad