Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp817603pxk; Mon, 31 Aug 2020 01:40:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyafo1Sn6q+w12n2Qk8GQoH2PsYpJ0jWFwxdj3FcuGwfCjU0n+Wkr08p00rpo4Ann0vuJhu X-Received: by 2002:a17:906:6ad8:: with SMTP id q24mr144060ejs.192.1598863241258; Mon, 31 Aug 2020 01:40:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598863241; cv=none; d=google.com; s=arc-20160816; b=Xcp0iAAmKbHUM9VjHU4T9uFR1rsYdsiYBVHG3xr7fnJGsHIRNVLSMCc5evlqXdmSvP fGEC2176z6iGPNGG4Z/OsQNJmnigT44nEoGja8AWPfr2SY1X+lTvFKnE/UD6u/oVNQpu uSqz12GWoMJgXWbULafLnUPHEQLSbo2j1pCwYttoqvXmRoQ3lnqKRkeOWaf55nx5Vb0o vaUh6yxmUklkStOop/ViiTcMTTZXIp4j68uigFqe5aaehh9N1dh8ZqMdSVmpdWe9uQbY E/b+3Rlhoq4YqFeyFx76C6GsnU84gkCjqubFQ4zVCU6ZmB80qLOCJWYnMbvFIK/ANATT vWfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=varRt3Ade1tYSVnTF1AZxSFWn/CDFBjbuZLbxbxlByI=; b=OLPA6WlLjqaHSJ/kUSA5gbKFaDumuFCR5Mg6sYvsc5gNX7By01MbQCtV1ZQ+8tkpEa WN6fh+QGCqO+azn6pkfBSuMRENPAot1HUyrESgHKTiWVvpkMBn2IqD0JRc3kWlXNs9fI d+M7NaT70cskgSsOSZO0F8kAnAvyLkf/g8F7dBUtIs+XRj5VcQaeUD6Irkmp/51aW7Jy 150Xeasbvio7mNq2QmhzssUYLda1uA9IgnpIkY9kjJ45FjvMkDryKiGXdzfvKDvvc6Zc vp7/xvz9CVecgygc50+UG8BRwAjHDDaUGFQ/7XVvLvRK5hz3ADr2/bg9+LnIAdzTRlfS frcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0DNDIqwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si4427555edv.170.2020.08.31.01.40.18; Mon, 31 Aug 2020 01:40:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0DNDIqwV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728182AbgHaIjG (ORCPT + 99 others); Mon, 31 Aug 2020 04:39:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59652 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725978AbgHaIjG (ORCPT ); Mon, 31 Aug 2020 04:39:06 -0400 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63E822137B; Mon, 31 Aug 2020 08:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598863145; bh=/mTBwH0H2XS7YSaOFVh9wZUjDwDeG33keE7ZBUOqWL8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0DNDIqwVYE/LHMPUqsSOdHXnx3H56mMT3qGKhC9s3QEwOGKmmxQnu97kkJhw1RJaq 2GHqCupyOkmXsanizUsBDchdhqQPHXVlqMjtCKuydcx0+o6XIFHrHSKhUpFtyvlrsx xWZNqcvQMZs05rusutSFTe7ho3t4z/XQZbUThdD4= Received: by mail-ej1-f42.google.com with SMTP id b17so7346564ejq.8; Mon, 31 Aug 2020 01:39:05 -0700 (PDT) X-Gm-Message-State: AOAM532BFfH7Zek1BT1BKrmCo5g3F6qew6CzevyUkF9QOcPVoFh7gDpm FBb6jEWOnAmO0x70xHbVDP4LDVsuaksKehvnhhY= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr111095ejx.215.1598863144013; Mon, 31 Aug 2020 01:39:04 -0700 (PDT) MIME-Version: 1.0 References: <20200830135200.24304-1-krzk@kernel.org> <20200830135200.24304-23-krzk@kernel.org> In-Reply-To: From: Krzysztof Kozlowski Date: Mon, 31 Aug 2020 10:38:52 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 23/33] ARM: dts: exynos: Remove empty camera pinctrl configuration in Odroid X/U3 To: Marek Szyprowski Cc: Rob Herring , Kukjin Kim , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Denis GNUtoo Carikli , Simon Shields , Bartlomiej Zolnierkiewicz , Sylwester Nawrocki Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2020 at 10:31, Marek Szyprowski wrote: > > Hi Krzysztof, > > On 30.08.2020 15:51, Krzysztof Kozlowski wrote: > > The camera's pinctrl configuration is simply empty and not effective. > > Remove it to fix dtbs_check warning: > > > > arch/arm/boot/dts/exynos4412-odroidx.dt.yaml: camera: pinctrl-0: True is not of type 'array' > > > > Signed-off-by: Krzysztof Kozlowski > > I think that this was intentional to properly enable support for > mem-2-mem mode in Exynos4-IS (FIMC), but I'm not sure what are the > default values if no pinctrl properties are provided. Sylwester, could > you comment? Indeed it could be intentional... I see now errors: [ 33.752203] s5p-fimc-md soc:camera: Failed to get pinctrl: -19 I wonder why getting an empty pinctrl is needed... maybe the driver should accept missing pinctrl? Best regards, Krzysztof