Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 09/33] ARM: dts: exynos: Add and enable 32 kHz modem
 clock in Origen
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Kukjin Kim <kgene@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Denis GNUtoo Carikli <GNUtoo@cyberdimension.org>,
        Simon Shields <simon@lineageos.org>
Cc:     Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Sylwester Nawrocki <snawrocki@kernel.org>
From:   Marek Szyprowski <m.szyprowski@samsung.com>
Message-ID: <0f898c36-714c-43ef-2afc-7843d444b41b@samsung.com>
Date:   Mon, 31 Aug 2020 11:16:09 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
        Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200830135200.24304-9-krzk@kernel.org>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200830135200.24304-1-krzk@kernel.org>
        <CGME20200830135426eucas1p19a79abc3fcc3580f466782a856eb0c78@eucas1p1.samsung.com>
        <20200830135200.24304-9-krzk@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Krzysztof,

On 30.08.2020 15:51, Krzysztof Kozlowski wrote:
> The PMIC has a 32768 Hz clock used by the modem which is implemented by
> driver as a regulator.  Add and enable it to be sure modem get's its
> signal.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Origen board doesn't have any modem/cp, so I see no point in enabling 
this clock.

> ---
>   arch/arm/boot/dts/exynos4210-origen.dts | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
> index 747221bbb856..fcf45619a3e4 100644
> --- a/arch/arm/boot/dts/exynos4210-origen.dts
> +++ b/arch/arm/boot/dts/exynos4210-origen.dts
> @@ -298,6 +298,11 @@
>   				regulator-name = "EN32KHZ_AP";
>   				regulator-always-on;
>   			};
> +
> +			EN32KHZ_CP {
> +				regulator-name = "EN32KHZ_CP";
> +				regulator-always-on;
> +			};
>   		};
>   	};
>   };

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland