Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Alexander Dahl <ada@thorsis.com>
To:     Jacek Anaszewski <jacek.anaszewski@gmail.com>
Cc:     linux-leds@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
        Dan Murphy <dmurphy@ti.com>, linux-kernel@vger.kernel.org,
        Alexander Dahl <post@lespocky.de>
Subject: Re: [PATCH] leds: pwm: Allow automatic labels for DT based devices
Date:   Mon, 31 Aug 2020 11:20:09 +0200
Message-ID: <1837645.vzTIdMnA0P@ada>
In-Reply-To: <eff509d5-a5f7-0d5d-b39c-aac364e53aca@gmail.com>
References: <20200826093737.29008-1-ada@thorsis.com> <7920560.iacgkFlgr8@ada> <eff509d5-a5f7-0d5d-b39c-aac364e53aca@gmail.com>
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Jacek,

Am Freitag, 28. August 2020, 22:43:02 CEST schrieb Jacek Anaszewski:
> On 8/28/20 9:00 AM, Alexander Dahl wrote:
> > Am Donnerstag, 27. August 2020, 23:28:45 CEST schrieb Jacek Anaszewski:
> >> This part looks good, but corresponding update of
> >> Documentation/devicetree/bindings/leds/leds-pwm.txt is needed as well.
> >=20
> > I'm not sure, what needs updating. The properties 'function' and 'color'
> > are already documented in
> > Documentation/devicetree/bindings/leds/common.yaml =E2=80=A6 the only t=
hing I can
> > think of here is updating the examples? That would be nice, as would be
> > updating to yaml, but I don't see the strong relation, yet.
> It is necessary to tell the user that given driver is capable of
> utilizing a property. I thought of something like in commit [0].
>=20
> >> It would be good to switch to yaml by this occassion.
> >=20
> > Is there some guidance on that in general?
>=20
> I am not aware of, but surely sooner or later all bindings will
> need to be unified. Touching the file is always a good opportunity
> to address that. It's up to you, though.

This update from txt to yaml is a manual task and after reading [1] and som=
e=20
other examples, I tried to come up with something.  I pushed the WIP to my=
=20
GitHub tree and will run the checks recommended by [1] later in the evening=
=2E =20
If that goes well, I'll send a v2 series.

> [0]
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit=
/Do
> cumentation/devicetree/bindings/leds/leds-lm3692x.txt?id=3D4dcbc8f8c59f4b=
618d6
> 51f5ba884ee5bf562c8de

Well okay, that was for the old format, but I see what you mean.

Greets
Alex

[1] https://www.kernel.org/doc/html/latest/devicetree/writing-schema.html