Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp835126pxk; Mon, 31 Aug 2020 02:22:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxWx83tW2PdkxrJRKgAyXp8ljopk9zleMA9v6AtPRo1BkBLl5w+4KDbE8lj9To+3JLnqC7H X-Received: by 2002:aa7:c805:: with SMTP id a5mr344177edt.60.1598865768968; Mon, 31 Aug 2020 02:22:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598865768; cv=none; d=google.com; s=arc-20160816; b=kzw2IGjZyPq/df14vLp2rgtFHmcs5eAtfe1eR1ulLaSTAtWJHmzT/y8+OEAV0gXmNE N2eGWLcnY4pNyqcCkuQyfuObT1pXL1pbKafnp07/MLghaanODJoQPp+r2z2J/mfMpUxV hrON01WBr0xgunIi+lpgmLe2mppQIuMdhAScCV1ipR95rf/7JKiW0SMIL+vYtZg7gWVb 0nhJpXpQBn7eO9ngtLLtP/2qTbV+vncJiIMmu/JhePsISbbrA3FgnSlmi7ZC7Hejui1r Vgf9iiHK4kpMaMDUeV10uAh+YeqsDmNRVNTsZP5sQSA9Qzxc0LGJtPpHb8O82ZkihaT0 ItYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=eU7W4qsDbkdoJXDiGXYUfxNJ4cfF6MmwHUNsUTUHXXo=; b=oEjdN3c+mxyu/55I97MmBlc2nrUCZs/TKqmWySgaFfv3Ij2yp5oXfxlt18Whl4bPvM W1hj0UhX+E6wXWZ63K7D08ilDYWsD382RLWyHvu24TsUTORMCy4pYA1ehZ6gbyfdDJ3g j4UelGna9MVXglUXderpa54w7NLUUJl+ORrprMKlz4VfpRq70+gIaSwqnh7Ww1xFiZjn jvD4E/KHuIcrsEqUnO0+BYHCgVfYQxuHR1ZwS3nl9xGRZ+dEBw49gHerKzZVll0fp5XC 3rA5O4w8976ZvQWx+uJI2spv8qeZr0s1iAdyKZNtvCCiDVTEI2Ax3ldSIZKBWoU+HQxg tEOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pYmVfXeY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v8si5226243ejw.434.2020.08.31.02.22.26; Mon, 31 Aug 2020 02:22:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pYmVfXeY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728363AbgHaJTm (ORCPT + 99 others); Mon, 31 Aug 2020 05:19:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:55198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728103AbgHaJTl (ORCPT ); Mon, 31 Aug 2020 05:19:41 -0400 Received: from localhost (unknown [122.171.38.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CC4DF2073A; Mon, 31 Aug 2020 09:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598865580; bh=VbOMNr9+mlKhviNnhhuAnntR0pqtI1g4GOH3sYhR2rk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pYmVfXeYXprV+l9Ii2m95YRdQE1u0CZ2sGQXb89oayh7pHNcWGejr4Z+IsUA9+9o8 DJ+rSfKQV0Zk2gL8HEQWveffbA6/CRSnIme71+fXGJLN9FxTehkzrb5iq6Dns5vWI+ Xj6gWxTR94UlPEHvT+JFXM+Dff1NwyZZbSGRC6ik= Date: Mon, 31 Aug 2020 14:49:36 +0530 From: Vinod Koul To: Wan Ahmad Zainie Cc: kishon@ti.com, robh+dt@kernel.org, andriy.shevchenko@intel.com, eswara.kota@linux.intel.com, vadivel.muruganx.ramuthevar@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v7 3/3] phy: intel: Add Keem Bay eMMC PHY support Message-ID: <20200831091936.GM2639@vkoul-mobl> References: <20200821113747.2912-1-wan.ahmad.zainie.wan.mohamad@intel.com> <20200821113747.2912-4-wan.ahmad.zainie.wan.mohamad@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200821113747.2912-4-wan.ahmad.zainie.wan.mohamad@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-08-20, 19:37, Wan Ahmad Zainie wrote: > +/* From ACS_eMMC51_16nFFC_RO1100_Userguide_v1p0.pdf p17 */ > +#define FREQSEL_200M_170M 0x0 > +#define FREQSEL_170M_140M 0x1 > +#define FREQSEL_140M_110M 0x2 > +#define FREQSEL_110M_80M 0x3 > +#define FREQSEL_80M_50M 0x4 > + > +#define maskval(mask, val) (((val) << (ffs(mask) - 1)) & mask) Kernel has a macro do this for you, please use FIELD_PREP instead of your own macro -- ~Vinod