Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp843316pxk; Mon, 31 Aug 2020 02:41:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRZsgM/Gmhp1NNs6NnnnGyVg2oQQctAsfCS1IbrUNbCqsWEMTaR5iOK6TyxT9GKDzMM/E8 X-Received: by 2002:aa7:da0f:: with SMTP id r15mr358373eds.321.1598866873158; Mon, 31 Aug 2020 02:41:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598866873; cv=none; d=google.com; s=arc-20160816; b=PxB1oPw7kSIw/hVf61pzp/sV5SO9A45Dd1LqvKo9V3KK96Lp04b3qN+TKxuqnDtX/Q DffX/SV7FlZ4pdh9P3bNp/s4hMiWXKbzh+IgCBnG7QjSYUL/LDIGMWS/lzpTQ2a0V3gA +e0N+gsmH/40NLmtaU6Ko27eZzbA7+LVj2EjWJ5RiJFnpSz3rGWhsRAVXn45aedglxu6 P+9DobasjXiZsanOAJVOpSpX7rzO5VyHqLI2+f1s8HsPCA297j9tFzoPLPdlJA4vAE7l OoQGfjJAl1YPj0FP5XrtuhejaiaARKNuWTz0eqHA9ssVlMit0rqitmo+7MzoFbaPpPhP mOGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=3xcD95Omn7OZHStzkmP410atDSIcvhVEzmyv5k2J5xk=; b=SNrmhMeZ0KMIY8Xl9sBzMcJyIk9JXekg19BPOuSz/nvjMdp5tWbbAP81cnpewkG9bw EsKOfptTns0Rax6z1Z2oVx3vXW/SwJm55/jCsBx8XUY2Fb0tA2PjeceNUXht0RdBZPok F4eDDySynhdS1lb2Xn4BoA0/FwMuZxd1lTKDJ3kqTL/aqoGpQGcetBpvyg5+hIg7Hs6v QVfiEN9sd6/1dlD9q9bMdL63+bObk/dh4fLnd3gz0njEEgZKdrJfauY+YwrRmmSSWhha BSe+U5C1naSwR2/q/bE068/2j1kitqhvxTkE0ova6b3IjyMV8Vd7/X3WXNT4J7pA0u7n GzyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i22si4963772edr.232.2020.08.31.02.40.50; Mon, 31 Aug 2020 02:41:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbgHaJkE (ORCPT + 99 others); Mon, 31 Aug 2020 05:40:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:54478 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbgHaJkC (ORCPT ); Mon, 31 Aug 2020 05:40:02 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 49735ACDB; Mon, 31 Aug 2020 09:40:34 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5CCC3DA840; Mon, 31 Aug 2020 11:38:48 +0200 (CEST) Date: Mon, 31 Aug 2020 11:38:48 +0200 From: David Sterba To: Max Staudt Cc: David Sterba , linux-fsdevel@vger.kernel.org, Geert Uytterhoeven , linux-m68k@vger.kernel.org, glaubitz@physik.fu-berlin.de, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] fs/affs: Fix basic permission bits to actually work Message-ID: <20200831093848.GS28318@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Max Staudt , David Sterba , linux-fsdevel@vger.kernel.org, Geert Uytterhoeven , linux-m68k@vger.kernel.org, glaubitz@physik.fu-berlin.de, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20200827154900.28233-1-max@enpas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200827154900.28233-1-max@enpas.org> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 27, 2020 at 05:49:00PM +0200, Max Staudt wrote: > The basic permission bits (protection bits in AmigaOS) have been broken > in Linux' affs - it would only set bits, but never delete them. > Also, contrary to the documentation, the Archived bit was not handled. > > Let's fix this for good, and set the bits such that Linux and classic > AmigaOS can coexist in the most peaceful manner. > > Also, update the documentation to represent the current state of things. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Signed-off-by: Max Staudt Thanks, patch looks good to me, I'll send a pull request to Linus this week.