Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: W3PC5hGe5avBR6wK26Ljwg9a2bIwIfJ+/qCgBHrNtw4xOhESFsPD6OYDenct+/opwro5N8TZrY
 6psl6sUJtivw==
IronPort-SDR: omwp4a9fl6Y7IKJt472Dl9ir83vgev5zrmdnxU+tY8B4HZIMUCFvIJ1YcKC8eExQziDf8737n9
 02e522+uo+aA==
Date:   Mon, 31 Aug 2020 13:47:03 +0300
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     =?iso-8859-1?Q?K=E9vin_L'h=F4pital?= <kevin.lhopital@bootlin.com>
Cc:     linux-media@vger.kernel.org, robh+dt@kernel.org,
        mark.rutland@arm.com, mripard@kernel.org, wens@csie.org,
        yong.deng@magewell.com, mchehab+samsung@kernel.org,
        p.zabel@pengutronix.de, hans.verkuil@cisco.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        paul.kocialkowski@bootlin.com, thomas.petazzoni@bootlin.com
Subject: Re: [PATCH v2 1/4] media: sun6i-csi: Fix the bpp for 10-bit bayer
 formats
Message-ID: <20200831104703.GI31019@paasikivi.fi.intel.com>
References: <20200828131737.12483-1-kevin.lhopital@bootlin.com>
 <20200828131737.12483-2-kevin.lhopital@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200828131737.12483-2-kevin.lhopital@bootlin.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi K?vin,

Thanks for the patch.

On Fri, Aug 28, 2020 at 03:17:33PM +0200, K?vin L'h?pital wrote:
> 10-bit bayer formats are aligned to 16 bits in memory, so this is what
> needs to be used as bpp for calculating the size of the buffers to
> allocate.
> This function is only used to generate the number of bytes per line.
> 
> Fixes: 5cc7522d8965 ("media: sun6i: Add support for Allwinner CSI V3s")
> Signed-off-by: K?vin L'h?pital <kevin.lhopital@bootlin.com>
> ---
>  drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> index c626821aaedb..8b83d15de0d0 100644
> --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi.h
> @@ -100,7 +100,7 @@ static inline int sun6i_csi_get_bpp(unsigned int pixformat)
>  	case V4L2_PIX_FMT_SGBRG10:
>  	case V4L2_PIX_FMT_SGRBG10:
>  	case V4L2_PIX_FMT_SRGGB10:
> -		return 10;
> +		return 16;

Does the same also apply to the 12-bit formats below?

>  	case V4L2_PIX_FMT_SBGGR12:
>  	case V4L2_PIX_FMT_SGBRG12:
>  	case V4L2_PIX_FMT_SGRBG12:

-- 
Sakari Ailus