Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030284AbWEYRDI (ORCPT ); Thu, 25 May 2006 13:03:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030285AbWEYRDI (ORCPT ); Thu, 25 May 2006 13:03:08 -0400 Received: from amsfep17-int.chello.nl ([213.46.243.15]:16054 "EHLO amsfep20-int.chello.nl") by vger.kernel.org with ESMTP id S1030284AbWEYRDH (ORCPT ); Thu, 25 May 2006 13:03:07 -0400 Subject: Re: [PATCH 1/3] mm: tracking shared dirty pages From: Peter Zijlstra To: Christoph Lameter Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Andrew Morton , David Howells , Christoph Lameter , Martin Bligh , Nick Piggin , Linus Torvalds In-Reply-To: References: <20060525135534.20941.91650.sendpatchset@lappy> <20060525135555.20941.36612.sendpatchset@lappy> Content-Type: text/plain Date: Thu, 25 May 2006 19:03:02 +0200 Message-Id: <1148576582.10561.83.camel@lappy> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1021 Lines: 22 On Thu, 2006-05-25 at 09:27 -0700, Christoph Lameter wrote: > On Thu, 25 May 2006, Peter Zijlstra wrote: > > > - rebased on top of David Howells' page_mkwrite() patch. > > I am a bit confused about the need for Davids patch. set_page_dirty() is > already a notification that a page is to be dirtied. Why do we need it > twice? set_page_dirty could return an error code and the file system can > use the set_page_dirty() hook to get its notification. What we would need > to do is to make sure that set_page_dirty can sleep. Ah, I see what you're saying here. Good point, David, Hugh? The reason I did it was because of Hugh's trick to use MAP_SHARED protection and building on top of it naturally solves the patch conflict Andrew would have had to resolve otherwise. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/