Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nilesh Javali <njavali@marvell.com>
To:     Xianting Tian <tian.xianting@h3c.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
Thread-Topic: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
Thread-Index: AQHWfdsk2b/ryS/vZ06xqJFnAbz5JKlSGq5w
Date:   Mon, 31 Aug 2020 11:41:26 +0000
Message-ID: <DM6PR18MB3052E1B8F65AA24F80530E37AF510@DM6PR18MB3052.namprd18.prod.outlook.com>
References: <20200829075746.19166-1-tian.xianting@h3c.com>
In-Reply-To: <20200829075746.19166-1-tian.xianting@h3c.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 662adcee-58ad-4d78-176d-08d84da2cb30
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2020 11:41:26.1302
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PyJQ4sTCw5OjJmEmwrxINh6wYSgCbCyPYCqVcvFwD8KC0mIXIGMdko5PGG137mibfD7vWnqpRo+N3BcjC0cuhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3212
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-08-31_04:2020-08-31,2020-08-31 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Xianting Tian,

Thanks for the patch.

> -----Original Message-----
> From: Xianting Tian <tian.xianting@h3c.com>
> Sent: Saturday, August 29, 2020 1:28 PM
> To: Nilesh Javali <njavali@marvell.com>; GR-QLogic-Storage-Upstream <GR-
> QLogic-Storage-Upstream@marvell.com>; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; Xianting Ti=
an
> <tian.xianting@h3c.com>
> Subject: [EXT] [PATCH] scsi: qla2xxx: Fix the return value
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> A negative error code should be returned.
>=20
> Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
> ---
>  drivers/scsi/qla2xxx/qla_target.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/scsi/qla2xxx/qla_target.c
> b/drivers/scsi/qla2xxx/qla_target.c
> index fbb80a043..612e001cc 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -3781,7 +3781,7 @@ int qlt_abort_cmd(struct qla_tgt_cmd *cmd)
>  		    "multiple abort. %p transport_state %x, t_state %x, "
>  		    "se_cmd_flags %x\n", cmd, cmd->se_cmd.transport_state,
>  		    cmd->se_cmd.t_state, cmd->se_cmd.se_cmd_flags);
> -		return EIO;
> +		return -EIO;
>  	}
>  	cmd->aborted =3D 1;
>  	cmd->trc_flags |=3D TRC_ABORT;
> --
> 2.17.1

Acked-by: Nilesh Javali <njavali@marvell.com>