Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4/4] arm64: dts: rockchip: enable rk3328-rock64 usb3 nodes
To:     lindsey.stanpoor@gmail.com, linux-usb@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org
Cc:     gregkh@linuxfoundation.org, cnemo@tutanota.com, robh+dt@kernel.org,
        heiko@sntech.de, balbi@kernel.org
References: <20200826170623.15469-1-travelvia@airmail.cc>
 <20200826171230.17041-1-lindsey.stanpoor@gmail.com>
 <20200826171230.17041-2-lindsey.stanpoor@gmail.com>
From:   Johan Jonker <jbx6244@gmail.com>
Message-ID: <9751e24e-1fe2-33ab-4fa5-019af9ea7746@gmail.com>
Date:   Mon, 31 Aug 2020 13:49:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200826171230.17041-2-lindsey.stanpoor@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Cameron,

Increase the version number for each new patch serie.

git format-patch -v4 -4 HEAD

In a previous comment I gave a sort example.
However, this patch serie is about usb3, so only touch the things
related to usb3 and leave the &uart2 node (legacy ;) ) untouched.

Improve the way in which your patches are send.

Your previous serie was incomplete.
Submit all patches with the same news server (Gmail for example) that
can handle plain text, because else you get 2 different Message-Ids:
<20200826171230.17041-2-lindsey.stanpoor@gmail.com>
<20200826170623.15469-2-travelvia@airmail.cc>

git send-email --suppress-cc all --annotate --to <..> --cc <..> <patch1
patch2>

Not sure how robh filters patches, but your serie 'must' show up in the
link below or else wait for an eternity to get a ack-by.

https://patchwork.ozlabs.org/project/devicetree-bindings/list/


On 8/26/20 7:12 PM, lindsey.stanpoor@gmail.com wrote:
> From: Cameron Nemo <cnemo@tutanota.com>
> 
> Enable USB3 nodes for the rk3328-based PINE Rock64 board.
> 
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Cameron Nemo <cnemo@tutanota.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> index 86cfb5c50a94..82c27eab6a52 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
> @@ -363,10 +363,6 @@ &tsadc {
>  	status = "okay";
>  };
>  

> -&uart2 {
> -	status = "okay";
> -};
> -

>  &u2phy {
>  	status = "okay";
>  
> @@ -379,11 +375,24 @@ u2phy_otg: otg-port {
>  	};
>  };
>  

> +&uart2 {
> +	status = "okay";
> +};
> +

Don't touch/change.

>  &usb20_otg {
>  	dr_mode = "host";
>  	status = "okay";
>  };
>  
> +&usbdrd3 {
> +	status = "okay";
> +};
> +
> +&usbdrd_dwc3 {
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
>  &usb_host0_ehci {
>  	status = "okay";
>  };
>