Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp981408pxk; Mon, 31 Aug 2020 06:50:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkdnreI5SnICKelSL6VTepfczC+a4GroY6JdWJgcC4ufQONRe0g2LL3/CpaZhxOKqZLZut X-Received: by 2002:a17:906:c2c5:: with SMTP id ch5mr1310279ejb.183.1598881855333; Mon, 31 Aug 2020 06:50:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598881855; cv=none; d=google.com; s=arc-20160816; b=kcitVoF6kGwJjwGoLEX4Se9VC9O9PTzQDjoapJMqaK1pwCv6CgyFN2NIM14DqVEJck eE7EGvnXTB9jOdDgmO9+K+v5G54JpeEqyJB4WbhZKRuNp+gbWjcxxuqGg/wTdm/iujjr HNXEnURYK8uoJQ69gPDoXFtejZvws5KzJjR51SIjiakbt6tzwZHyVZ0dnW00FjPxaEfu dY79NmpoUK9VuI3knsZB49PljYp05jiuUUPOwJo8Qk8o4AicVxvZDdeFWEJbl3Dsdeuh dyCx6g9/+fdvKe/jkxeTT118W/ePiC1UJM3lNQpJstUddAwa17rfOIwdQMS6s81yfOg5 hkcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=7XrKIEjokhT39cb4dngP7JBKkU6deHs5tXu4INGwQow=; b=t+s/WYXwNBKKnsVKSek2uDinawDZSLCXzlbyTzZE+ac4rZY/iCXTkUGwUD2Ns81oep 24jAVxdqdqsMAZlu1O9drnw6MVhu+fWn5dKZu3U5RbYOtLwbv15BG1TZz6oBUPoHQZ4l lzqQhrfGJ8RS896Xa5yza6AZYCJ6P6DUTSfMOzJxCH5Kae8zcMSvFxms9Nj+C81jlxpW WEjHxrv5N92bQQo0sYE3cKlH5y/PP1XcXo9XDcKH1pyt1EL5rJ8JuUU8rKNOdfAlmePE 4bU4n8OP2BYL0GzU9bKlcbibsQ1GxNqKBg2VpOW7GQlo4MVG2FVkdJgYBJxOp3mFEqJC 9dQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KCWN1aD6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i16si5283962edb.5.2020.08.31.06.50.32; Mon, 31 Aug 2020 06:50:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=KCWN1aD6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726489AbgHaNqx (ORCPT + 99 others); Mon, 31 Aug 2020 09:46:53 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:36698 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbgHaNqS (ORCPT ); Mon, 31 Aug 2020 09:46:18 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07VDipvu082687; Mon, 31 Aug 2020 13:46:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=7XrKIEjokhT39cb4dngP7JBKkU6deHs5tXu4INGwQow=; b=KCWN1aD6eukPdtoLctc1Q+Pj9jHE4tn5AxjXIZSjwNIri2p36JYknCZKOAZZX6X5eYSt YO7hJNcpfmu0PPyoXxYLxLHduULiUT/3enzYamN2zuy4IUBGYybSc1j4sxRbtTKVoAnk NHVqlg6PikYRGwaPcgxVEZ43WNLuuu+jHJZe+2f4oYbAuWqv2hOE7Rd4X8SrJjKfqT5E 0SbB4/lcJf9F+tGHxhVPPUVbn5AtN0+PDLZdjBLXIaa1uuWOtp0gMwq7el4379tIATe6 asOJoFeEdPdkN28+QP8qbzxWZBrG8MtGhK2tu/FVhHunzK+e8Fophjj1ggIBYc5b0fr1 wg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 337eeqpb97-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 31 Aug 2020 13:46:06 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07VDjA0q158834; Mon, 31 Aug 2020 13:46:05 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 3380kknhsk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 31 Aug 2020 13:46:05 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 07VDk4i7003609; Mon, 31 Aug 2020 13:46:04 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 31 Aug 2020 06:46:04 -0700 Date: Mon, 31 Aug 2020 16:45:57 +0300 From: Dan Carpenter To: Cengiz Can Cc: devel@driverdev.osuosl.org, Mauro Carvalho Chehab , "Gustavo A . R . Silva" , linux-kernel@vger.kernel.org, Sakari Ailus , Andy Shevchenko , linux-media@vger.kernel.org Subject: Re: [PATCH] staging: atomisp: Fix fallthrough keyword warning Message-ID: <20200831134557.GW8299@kadam> References: <20200831133011.91258-1-cengiz@kernel.wtf> <20200831134021.GV8299@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831134021.GV8299@kadam> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9729 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310080 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9729 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 mlxscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008310080 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Really I think this function is pretty buggy. It shouldn't be falling through at all... I reported it a couple days back so it's possible that someone is working on a fix already. regards, dan carpenter