Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp981520pxk; Mon, 31 Aug 2020 06:51:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxqUjKzXr8l+qO52fKu8mTAd2j5iwZzqpRrmBnp4KvnQeE+GGQ7PZN9Bg25sl+8u/7+ga72 X-Received: by 2002:a17:906:2a1a:: with SMTP id j26mr1253913eje.456.1598881868358; Mon, 31 Aug 2020 06:51:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598881868; cv=none; d=google.com; s=arc-20160816; b=qyUOWAT0SePI8vSO2iSjgl9U+/rent/Kh53deTtvwz36sUuHru0h52eVs4vaE3Y1W+ JwL6jtVM7IT7m90K8sf9G5Szi2RAPt+FnP2kMLx5KKJcGZn0WDsPpQFDuLXqLY8YD+5v SAQgxaFGgjkrJuMYz8TJ46j8jxlAy9xgJkL5k5NC3BiRASZ1WTxgTZap5k/HpND0BlEp AA2/RmSZ1cyyjpO/nX4I3swrU9zjikkRQXI6YZc7G9DPVvz7ahu6t0GSFygZvOhQPOAR iWvX9A2r+w4CwPloDRPrZcK8FMxCjIflJ20tTO1DFKD+NSMH+95C0c5PRyuHqvnxYset fAeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wLMxdLz5QAarNCYXaP+rWrS0jWXxEpCx7skMQJRMXj0=; b=zcwOb/ustvr30eskXNcDXFl3xW3tvbQk3m2gwZ/MbLNfRcf/ZWDsGGaSNLqXm76xkR 0+bX1xaupdJtwIPxyKUB51DJd6YzE9fqLvF2QONT4VEed1BJQ5O7p10LbLkn7Q4G8X3g ly/+oGnkJSUiwYB2dup8eyZZ7vnn9eZJzqgPzROLP0M36ada99uGZlm1rHQK/+V2MvGw Hes2faZenxxAOn3rdiPKIb9G3AVBBcC1ZLe/j+4VVlNBa9KavOtSo0uX9gFVVplW78Zl znr/1Ms4HFgspYs+kVASPffKBPlw5YQMZA1KEPRjuN8eOmnn1SSmHkl19vlP5MrgKeQu /xWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="vYV/FGnl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si5608637ejv.155.2020.08.31.06.50.45; Mon, 31 Aug 2020 06:51:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="vYV/FGnl"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727786AbgHaNuK (ORCPT + 99 others); Mon, 31 Aug 2020 09:50:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:42146 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgHaNuH (ORCPT ); Mon, 31 Aug 2020 09:50:07 -0400 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6936214D8; Mon, 31 Aug 2020 13:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598881807; bh=ztLmZ+941EYqr7AcuVlAnDkvVWFOEg0Wm9jORnDkfUk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=vYV/FGnlQ06Mj/nnQX76wRgv2qFhTHS7eVvVPBLvjpO93baFcabyDVe+wYQC1Lh/9 /QyPf451GSDyQH6zTMXYOggTlJyPDU0J/9TRQJa1M3PVfN8lyPGbPgU2+hcUYgPH/W y7q1CTt1RI1xlnnrSJpNG2oXDCfTI9ekdZZNsZj0= Received: by mail-ej1-f41.google.com with SMTP id b17so8570941ejq.8; Mon, 31 Aug 2020 06:50:06 -0700 (PDT) X-Gm-Message-State: AOAM533s61NeNXu8scRgccjylTOak68a9Zn2VJZQIkNSZb9uNMIIuicN RBVLcfLyHrUbPfPt9Xrmv6ymsKosp07v30cvtSY= X-Received: by 2002:a17:906:8401:: with SMTP id n1mr1217460ejx.215.1598881805398; Mon, 31 Aug 2020 06:50:05 -0700 (PDT) MIME-Version: 1.0 References: <20200829142501.31478-1-krzk@kernel.org> <20200829142501.31478-10-krzk@kernel.org> <84ec0795-2b7f-adde-4277-2238cede8c24@samsung.com> In-Reply-To: <84ec0795-2b7f-adde-4277-2238cede8c24@samsung.com> From: Krzysztof Kozlowski Date: Mon, 31 Aug 2020 15:49:54 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 10/10] arm64: dts: exynos: Enable Arizona interrupt controller in Exynos5433 TM2 To: Marek Szyprowski Cc: Kukjin Kim , Rob Herring , David Airlie , Daniel Vetter , Lee Jones , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Daniel Lezcano , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org, Bartlomiej Zolnierkiewicz , Sylwester Nawrocki , Chanwoo Choi , Inki Dae Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2020 at 15:12, Marek Szyprowski wrote: > > > On 29.08.2020 16:25, Krzysztof Kozlowski wrote: > > The Wolfson Arizona codec is interrupt controller which is required by > > bindings. This fixes dtbs_check warnings like: > > > > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: 'interrupt-controller' is a required property > > arch/arm64/boot/dts/exynos/exynos5433-tm2e.dt.yaml: wm5110-codec@0: '#interrupt-cells' is a required property > > > > Signed-off-by: Krzysztof Kozlowski > > Tested-by: Marek Szyprowski > > However I really wonder if it makes sense to expose this to DTS. Indeed, > the main MFD device of the WM5110 chip is interrupt controller, but its > interrupts are requested internally by the respective drivers. In such case maybe the schema should be updated? Feel free to send a follow up or a replacement patch for this one. Best regards, Krzysztof