Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1043349pxk; Mon, 31 Aug 2020 08:18:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7J3cyQ82D6LmRQJiI7DXDJbn1048KfZ9RM1XHUTstb0iP1y51Bw/2qCwBj3JiRBI4GTxa X-Received: by 2002:a17:907:43f6:: with SMTP id mu6mr1666463ejb.244.1598887126974; Mon, 31 Aug 2020 08:18:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598887126; cv=none; d=google.com; s=arc-20160816; b=twQ5SxMYUF3sOJHd31QeaWZwK0TU79DgL1uhRDBqW5SMeB/vVesBkZdwNFc/aKgt6I iUffQ5aBUOmXsyC1lHfVEoGb1HLe9Qg8xqkhG0+rYTZOxTvDrAlF9L9q9O8PG+ImojN2 QNJN0rB38AKUO73sFpcl+TzYnLxvmA0bXI2JdDyTQ/bB+aQDxH8rV0ROCXBXhEClkiDp I/iEI8V7hzABmKECDko4iE5thpsCgsrbzjZoUR4iU6/Z1P9DvOCn2wCPXPHb/+MqLKPe L+ZyhOjz1SytJ42gtncwNDX4BYI60RtFxrMvxBm+oObaXvRierCE12+haa4rb0aMdYDk bltw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:ironport-sdr:ironport-sdr; bh=36x4fEK0nBanrDKkQqakqAfwU2FgKTDwST6axc9int8=; b=i+F+ziqfhi6q/ZSLAa6uRS/5WdCKNK1HHqSNmiROi17akGDHh4CEort9X1YDcXvznU LoRrm6mGyv5vnXIf8EkyC0ytL1GtM5nQuXabmwgUeWyDeTot5glG6SLX9vsu4TFxgi2Z wfy1VLeZc9KDDouvBxG15B19EiCl47Mjhov41hQuU5pKG+k4BE5jzkfnqTlPeWflHfWd 5nyDy2XLgjLfc6l54CTJ2VzohE+VrUD0aO5yScSGMLj7aaSIsdYv2kAK16ISBdE4PIyw zYNM37X/X0Fs+T6BQxVr+I7anIFLCmQI5+4eYx7gwnpYeLKVniGeotdA/QNEC8C12lTM gmiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d14si4172140edp.136.2020.08.31.08.18.24; Mon, 31 Aug 2020 08:18:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728190AbgHaPPn (ORCPT + 99 others); Mon, 31 Aug 2020 11:15:43 -0400 Received: from mga09.intel.com ([134.134.136.24]:37214 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726755AbgHaPPm (ORCPT ); Mon, 31 Aug 2020 11:15:42 -0400 IronPort-SDR: Jqv2qd2ZDwx60MNQUPK89BPVQr1+p5Guwuoo9yJ7xpgltdo9MtiHusTWe+a2wJrnXBEdmiIqTS 1Ld58yu5zfCQ== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="157998298" X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="157998298" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 08:15:41 -0700 IronPort-SDR: v+uBZj2yz55phQgP83igUTAsDBunmkJ9f49VrBbrIS3NM4KS8+6pGtYENeFcFdHxEM6jugM9Bv 4kF0z8JH/H9A== X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="501376518" Received: from jaeikcho-mobl.amr.corp.intel.com (HELO [10.213.165.6]) ([10.213.165.6]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 08:15:38 -0700 Subject: Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for clock-stop invalid configs To: Vinod Koul , Bard Liao Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, sanyog.r.kale@intel.com, mengdong.lin@intel.com, bard.liao@intel.com References: <20200829110047.GC2639@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: <051afb2d-dd2e-0ea4-d8a9-980f5df136b7@linux.intel.com> Date: Mon, 31 Aug 2020 10:15:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200829110047.GC2639@vkoul-mobl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>>> Detect cases where the clock is assumed to be stopped but the IP is >>>>>> not in the relevant state, and add a dynamic debug trace. >>>>> >>>>> you meant a debug print..and it looks like error print below (also in title). >>>> >>>> I don't understand the comment. Is the 'trace' confusing and are you asking >>>> to e.g. change the commit message to 'add dynamic debug log'? >>> >>> Question is what is dynamic about this? >> dev_dbg() is part of the kernel dynamic debug capability... >> >> https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html >> >> Not sure what you are asking here? > > :-| where is dev_dbg() ? > > See [1] > > [1] > >> + dev_err(dev, "%s invalid configuration, clock was not stopped", __func__); > > ^^^^^^^ it's still a log using the "dynamic debug" framework. Again, what are you asking us to fix?