Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Jqv2qd2ZDwx60MNQUPK89BPVQr1+p5Guwuoo9yJ7xpgltdo9MtiHusTWe+a2wJrnXBEdmiIqTS
 1Ld58yu5zfCQ==
IronPort-SDR: v+uBZj2yz55phQgP83igUTAsDBunmkJ9f49VrBbrIS3NM4KS8+6pGtYENeFcFdHxEM6jugM9Bv
 4kF0z8JH/H9A==
Subject: Re: [PATCH 09/11] soundwire: intel: add dynamic debug trace for
 clock-stop invalid configs
To:     Vinod Koul <vkoul@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>
Cc:     alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org,
        jank@cadence.com, srinivas.kandagatla@linaro.org,
        rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com,
        hui.wang@canonical.com, sanyog.r.kale@intel.com,
        mengdong.lin@intel.com, bard.liao@intel.com
References: <20200829110047.GC2639@vkoul-mobl>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Message-ID: <051afb2d-dd2e-0ea4-d8a9-980f5df136b7@linux.intel.com>
Date:   Mon, 31 Aug 2020 10:15:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200829110047.GC2639@vkoul-mobl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


>>>>>> Detect cases where the clock is assumed to be stopped but the IP is
>>>>>> not in the relevant state, and add a dynamic debug trace.
>>>>>
>>>>> you meant a debug print..and it looks like error print below (also in title).
>>>>
>>>> I don't understand the comment. Is the 'trace' confusing and are you asking
>>>> to e.g. change the commit message to 'add dynamic debug log'?
>>>
>>> Question is what is dynamic about this?
>> dev_dbg() is part of the kernel dynamic debug capability...
>>
>> https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html
>>
>> Not sure what you are asking here?
> 
> :-| where is dev_dbg() ?
> 
> See [1]

> 
> [1]
> 
>> +			dev_err(dev, "%s invalid configuration, clock was not stopped", __func__);
> 
>                          ^^^^^^^

it's still a log using the "dynamic debug" framework.

Again, what are you asking us to fix?