Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 31 Aug 2020 19:00:32 +0300
From:   Cengiz Can <cengiz@kernel.wtf>
To:     Jason Gunthorpe <jgg@ziepe.ca>
Cc:     Dennis Dalessandro <dennis.dalessandro@intel.com>,
        Mike Marciniszyn <mike.marciniszyn@intel.com>,
        Doug Ledford <dledford@redhat.com>,
        "Gustavo A . R . Silva" <gustavoars@kernel.org>,
        linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband: remove unnecessary fallthrough usage
In-Reply-To: <20200831153440.GA24045@ziepe.ca>
References: <20200831153033.113952-1-cengiz@kernel.wtf>
 <20200831153440.GA24045@ziepe.ca>
Message-ID: <33b7fe93c7fd17658baeabd233d38099@kernel.wtf>
User-Agent: Roundcube Webmail/1.3.15
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-08-31 18:34, Jason Gunthorpe wrote:
> On Mon, Aug 31, 2020 at 06:30:34PM +0300, Cengiz Can wrote:
>> Since /* fallthrough */ comments are deprecated[1], they are being 
>> replaced
>> by new 'fallthrough' pseudo-keyword.
>> 
>> [1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?\
>>         highlight=fallthrough#implicit-switch-case-fall-through
>> 
>> This sometimes leads to unreachable code warnings by static analyzers,
>> particularly in this case, Coverity Scanner. (CID 1466512)
>> 
>> Remove unnecessary 'fallthrough' keywords to prevent dead code
>> warnings.
>> 
>> Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
>> ---
>>  drivers/infiniband/hw/qib/qib_mad.c | 2 --
>>  1 file changed, 2 deletions(-)
> 
> Alex beat you to it:
> 
> https://patchwork.kernel.org/patch/11736039/

Well, I'm glad it's fixed :)

Thanks for sharing

> 
> Thanks,
> Jason

-- 
Cengiz Can
@cengiz_io