Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1106067pxk; Mon, 31 Aug 2020 09:54:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzYw8bdB/cYODK71vy3xSMyrokEq2ROood0tHbYL2piDM1rREIFncfsxtO31lJUpv92Sugr X-Received: by 2002:a17:906:29ca:: with SMTP id y10mr1824058eje.327.1598892863087; Mon, 31 Aug 2020 09:54:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598892863; cv=none; d=google.com; s=arc-20160816; b=DlQMil3rYgtqVW6xyOIYqawOTwIJ6ZIgIy+vybp4b+1bG/FDBvJkn0AuA5AlzTM51k rtWVdrjI7LtSJCG2g3SoY7EuzSTVcxopb7kNGVnK8PsEqALnUhfN/LSbwpIAEm58OA1N PqRAoeN/ZD0FZwbHtgze52nlICKvR+NImB5Gqw7Qn1A8raeziQMUks1skuEW4iYq/PA/ fdNLgf5Mv/DA7GBCn4x4sYVaHp3eFFnLUvfgVZ0Xl8fSsm1gvZ4IIbUroPE9nClvMkK3 zi/EUNIKnzs8cpFogbFjXdU6bYgXMJTANR88E5s5/v0C60J7El5/mMm3pzkspJzjuvqq k3BQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=BwrblQSNFRJLYEig6HxC1EMYKkVTQ7136QNUaOwp2Uo=; b=kn1x++xDgwF8Qmqy+dogEo49XoLURCBDgBozjPgVl7mgk+j3FmIBDPvqXTArK1KqcK gVVvv2RKlyINvV7zxBRgHE7nLEB3J4QljVorbdtDFgbyqJ+2FUdZgFFXcpr1gV94mToR Q1C+N5BRnkURiePC9AKB5gvl3r3+fryaXPZBPLtGnpJv8fUMOK5l0pk4+ZOB0q6dP3HN YVFOtpk+/XeonSOwAf7dNX/fMmLvf01OrFEKPz2HyP1kzW8af4Xc6xwmpgbyxtqlc9Rp VbjO6vPQCSpwkmdvlWixQSj/+o9n02P1q/CS03BD7FnmYXTZIvBkAboCdowd83sTnT+2 l61A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si5918996ejg.482.2020.08.31.09.54.00; Mon, 31 Aug 2020 09:54:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728834AbgHaQwZ (ORCPT + 99 others); Mon, 31 Aug 2020 12:52:25 -0400 Received: from mga01.intel.com ([192.55.52.88]:32509 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728772AbgHaQwZ (ORCPT ); Mon, 31 Aug 2020 12:52:25 -0400 IronPort-SDR: uQmyXIbDaE76I5btjcgNkFxTP1fKaZTdxPVobPta2pd2ZBrk4qboaYcFZNqR7Qx0PIk30Bi9Ck Ej+u7pulqyXg== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="175066387" X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="175066387" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 09:52:23 -0700 IronPort-SDR: W2+IE27pQLjMaQbC7PYHRurSpcOOAvO8WlyMWDfsKP/zKKBAXOlnNvxMwl67pea2uOmir0Z/fg 4h0UqW2z0TEg== X-IronPort-AV: E=Sophos;i="5.76,376,1592895600"; d="scan'208";a="476800745" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 09:52:23 -0700 Date: Mon, 31 Aug 2020 09:52:22 -0700 From: Ira Weiny To: John Hubbard Cc: Andrew Morton , Alexander Viro , Christoph Hellwig , Ilya Dryomov , Jens Axboe , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v3 3/3] bio: convert get_user_pages_fast() --> pin_user_pages_fast() Message-ID: <20200831165222.GD1422350@iweiny-DESK2.sc.intel.com> References: <20200831071439.1014766-1-jhubbard@nvidia.com> <20200831071439.1014766-4-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200831071439.1014766-4-jhubbard@nvidia.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 31, 2020 at 12:14:39AM -0700, John Hubbard wrote: > @@ -1113,8 +1113,8 @@ int bio_iov_iter_get_pages(struct bio *bio, struct iov_iter *iter) > } else { > if (is_bvec) > ret = __bio_iov_bvec_add_pages(bio, iter); > - else > - ret = __bio_iov_iter_get_pages(bio, iter); > + else > + ret = __bio_iov_iter_get_pages(bio, iter); Why the white space change? Ira