Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 Aug 2020 19:26:17 +0200
From:   Andreas Kemnade <andreas@kemnade.info>
To:     Jonathan =?UTF-8?B?TmV1c2Now6RmZXI=?= <j.neuschaefer@gmx.net>
Cc:     robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        Anson.Huang@nxp.com, marcel.ziswiler@toradex.com,
        sebastien.szymanski@armadeus.com, michael@walle.cc,
        rjones@gateworks.com, leoyang.li@nxp.com,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH v2 2/2] ARM: dts: imx: add devicetree for Tolino Shine 2
 HD
Message-ID: <20200831192617.3af13f1b@aktux>
In-Reply-To: <20200827183323.GE103070@latitude>
References: <20200826204251.5082-1-andreas@kemnade.info>
        <20200826204251.5082-3-andreas@kemnade.info>
        <20200827183323.GE103070@latitude>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Thu, 27 Aug 2020 20:33:23 +0200
Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net> wrote:

> On Wed, Aug 26, 2020 at 10:42:51PM +0200, Andreas Kemnade wrote:
> > This adds a devicetree for the Tolino Shine 2 HD Ebook reader. It is ba=
sed
> > on boards marked with "37NB-E60QF0+4A2". It is equipped with an i.MX6SL
> > SoC.
> >=20
> > Expected to work:
> > - Buttons
> > - Wifi
> > - Touchscreen
> > - LED
> > - uSD
> > - USB
> > - RTC
> >=20
> > Not working due to missing drivers:
> > - Backlight (requires NTXEC driver)
> > - EPD
> >=20
> > Not working due to unknown reasons:
> > - deep sleep (echo standby >/sys/power/state works),
> >   wakeup fails when imx_gpc_pre_suspend(true) was called.
> >=20
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > --- =20
> [...]
> > +		fl {
> > +			label =3D "Frontlight";
> > +			gpios =3D <&gpio3 26 GPIO_ACTIVE_LOW>;
> > +			linux,code =3D <KEY_BRIGHTNESS_CYCLE>;
> > +		}; =20
>=20
> Another option might be KEY_BRIGHTNESS_TOGGLE/KEY_DISPLAYTOGGLE, but
> it's not a perfect match, either. (And perhaps a worse match due to the
> connotation of turning the display off.)
>=20
I have also thought about these, but came to the same conclusion as you,
the connotation of turning the display off does not feel right.

>=20
> Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>
>=20
> Thanks

Regards,
Andreas