Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1299671pxk;
        Mon, 31 Aug 2020 15:41:58 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxbBSxB0y4aiiZo9TWnWU7GKaPfTeo+V/sWbdF1uy6OiuwMZ/l5qFoFVQEGKwMDkCbkxS/c
X-Received: by 2002:a05:6402:1451:: with SMTP id d17mr1549792edx.48.1598913718065;
        Mon, 31 Aug 2020 15:41:58 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598913718; cv=none;
        d=google.com; s=arc-20160816;
        b=Ji8kb0VTEMi+JOILzP56iRCHvx9JpBiiJhzG6DotzHZY+sx650R0zqUV2QBqWLos69
         +69kTpafb4Tsrnz4sCKsZWfIIfed6jg//Zv75mkWDnwrp4wFcaq15nI6R1DFeAoLXlyj
         BvOIuCAVIFBbdBC767/ciEBsOdrknlYuTM6t7rzKpx7ggLIDz/6zWfT5sQJL56ghbB1S
         eE8C8f1K8+ltwSXhmdw67zSxifC1vZeDqPPGjg5JFfOjTm0pw3C+SKyNM/4DYgD51EGA
         eAaVBo/YP9cRURAN+HJrpQrzf8DuiyEiR4ztwbHINTkun0HuH38et49QWUbyU5CWf5xA
         SulA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=a9xhv7tNp19Uz+cydQ34PaBIIFoobDnf3MY43zUBOyo=;
        b=EjfyasfthU348wVXx5XS1+VhD/B9OXEoDflFuke8DT00ihgOJFYoutyThkpA01mzCt
         Vp8M9bwYQpt/EbPXOM5aaiBc8TVRIKaB45m/2TE1n4OSbRnQcDm6LNqSmnLr4VFZ7Hal
         ubL3Zt7Rt/o2mlf2/1VkZsgczo5oglgB1dfWiuF4wR/omv40uK3bxAI22kjZvQaWxFaN
         VFLxtSqlMeKSMsvNaC7bt0YTcfhe6RD4xgZuNFh1UQ2QxuRD2xYWoez55reOMRIaBJhm
         A8D7cFVV67ocLu4fcmeXeaLGK0sdto3vRWm6JwHP5D7LDb8dcqgAOM0uieYfoK0AO6bs
         R4Lw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a5si6099836edx.243.2020.08.31.15.41.35;
        Mon, 31 Aug 2020 15:41:58 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729522AbgHaTXE (ORCPT <rfc822;learnos2017@gmail.com>
        + 99 others); Mon, 31 Aug 2020 15:23:04 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35342 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728785AbgHaTXE (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Aug 2020 15:23:04 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEE94C061573;
        Mon, 31 Aug 2020 12:23:04 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id CB9C412889ED4;
        Mon, 31 Aug 2020 12:06:16 -0700 (PDT)
Date:   Mon, 31 Aug 2020 12:23:02 -0700 (PDT)
Message-Id: <20200831.122302.1503509345904601478.davem@davemloft.net>
To:     xie.he.0141@gmail.com
Cc:     kuba@kernel.org, khc@pm.waw.pl, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, ms@dev.tdt.de
Subject: Re: [PATCH net] drivers/net/wan/hdlc_cisco: Add hard_header_len
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20200828070752.54444-1-xie.he.0141@gmail.com>
References: <20200828070752.54444-1-xie.he.0141@gmail.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 31 Aug 2020 12:06:17 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Xie He <xie.he.0141@gmail.com>
Date: Fri, 28 Aug 2020 00:07:52 -0700

> This driver didn't set hard_header_len. This patch sets hard_header_len
> for it according to its header_ops->create function.
> 
> This driver's header_ops->create function (cisco_hard_header) creates
> a header of (struct hdlc_header), so hard_header_len should be set to
> sizeof(struct hdlc_header).
> 
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>

Applied, thanks.