Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1299732pxk; Mon, 31 Aug 2020 15:42:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQ1uqVhTaXSFTpdMK6GAL8evOGlvXMRy/Ux192mSj+7eQE8Nca8+d9odMez5aUj0nuH5Lw X-Received: by 2002:a17:906:15cc:: with SMTP id l12mr3049355ejd.7.1598913724234; Mon, 31 Aug 2020 15:42:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598913724; cv=none; d=google.com; s=arc-20160816; b=Eo9Zg6L23keS7GeVGr7qwuYDvg4UyA+8t8sWPElcEtnOtHymItfYErVlQTi0Hjt15l ggX+wWSmDPkK0ujNX5AAWUT11J01/yTJxFtibckVWerOTs+SxjSxSY5vdx5c3X6L8jw8 OG4pOaCf3NWXc0xZSbd+ADDvj8grNli+zxYcT+/lnqK+lUKLS0h/RF9MRg2aM62WZfpW Sk0NQ82ficXwsnYM/wYK+uYmaXGKFUv9/nh44ryRDRFcZFLxy8ONw5yFWWjnsct5RcJ/ E2/r1H4HfrhnLkOE+rTGrtwd67MA2lJMJhgl3GPnAEdpSr6JnemzXCJ5DnFMX7BpcXFE vtSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=mCyU4saLb0ygbbeAgT91761BfXts2kXGJoSC4oNGGVE=; b=xYDwX+SPFiW1qLjL3YJHPZWm80qIn5Zm23q4cE3IoEx2yjEzmkNV3mNbivv17ELauI KsjDyAQcdpcQE9qXytjLNkKBEvq+5dJlLrQTcGEHeJy1PZ696+vJM/gPyHZVTWN+CA0p y/f8n5jjBvIHgJreoBY54N7IosVyqjRbsWQ+2LtikJmpUtdQtGWSp0X5ESF6PBgzSVnS 1+aSVWAtcBSz0CAKGYlhDrCC/Ccw71aHu67mknOB6FibrgKFKgQ+erxrfXKIdD/2QCZA lfE10+sp49pvSP/QSDyB66RvhFrEccCwDayMADSsfPWQo+HQscQScI1sjXmFjpXeWA/4 JZGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=atYzD5gp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pj10si1546185ejb.398.2020.08.31.15.41.41; Mon, 31 Aug 2020 15:42:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=atYzD5gp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728020AbgHaTP4 (ORCPT + 99 others); Mon, 31 Aug 2020 15:15:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:40682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725886AbgHaTP4 (ORCPT ); Mon, 31 Aug 2020 15:15:56 -0400 Received: from X1 (unknown [65.49.58.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69CBE2068F; Mon, 31 Aug 2020 19:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598901356; bh=GDy1fsI36v2ZyxfLvzTCNTXvzujrkKd4Gu/L2okdFrQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=atYzD5gpMnIG6BFdeJ/em0LdLf1SHIZektt7yokFaON6dBOuazpy6TdDZ1BDD4kRJ 7ibDldGN9Kh+T9Fz1RkWQHzdztYTxNdYBenNZkEWvazPxsPj0n9jfVuGJHpOk3HtB7 QYaGjrSXSPNiPT7D2uOWcEtCkPml7P6EQnn8sEac= Date: Mon, 31 Aug 2020 12:15:53 -0700 From: Andrew Morton To: Christian Borntraeger Cc: Gerald Schaefer , Linus Torvalds , linux-mm , LKML , Vasily Gorbik , Alexander Gordeev , linux-s390@vger.kernel.org, Heiko Carstens , Claudio Imbrenda Subject: Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding Message-Id: <20200831121553.8be5dcdbdbc5256846ac513e@linux-foundation.org> In-Reply-To: <9071c9fa-ba6a-90dc-2d7a-8b155141d890@de.ibm.com> References: <20200828140314.8556-1-gerald.schaefer@linux.ibm.com> <9071c9fa-ba6a-90dc-2d7a-8b155141d890@de.ibm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Aug 2020 13:53:36 +0200 Christian Borntraeger wrote: > > > On 28.08.20 16:03, Gerald Schaefer wrote: > have some feedback soon if option 1 or option 2 would be acceptable > from a common code perspective. Andrew, who of the mm people would > be the right one to decide? Jason and John Hubbard are doing most of the work in there at present, Both patches look OK to me from a non-s390 perspective. Unless we plan to implement Jason's more-general approach this time, I'd be inclined to defer to the s390 people as to the preferred implementation.