Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1305633pxk;
        Mon, 31 Aug 2020 15:53:50 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxS70I7prCxvDupNnGNtdPZnwXylr9oea/RTMwWTgcmcXuqzDSX7pN/UOSH6Js/u6FLyVQW
X-Received: by 2002:a17:906:f957:: with SMTP id ld23mr2878908ejb.187.1598914430763;
        Mon, 31 Aug 2020 15:53:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598914430; cv=none;
        d=google.com; s=arc-20160816;
        b=0CldcOfA8dGfD+Fg3HbPev/ysvtaBjPD9wJKiQlHypRDbnzpDrdzvKvftk9nnuFFg6
         Wf0pJI6rMFJrIxiDiLBvqbS3vVFQIFOgVSzDlO7RVqm87uqbnq8yFtpcl+VWEEbl194L
         E6t0yZmKHSBCEubGf2yS3Dvyw6PCu8KqLliprRuc9/IAbVI8qd+D9bHQKfGfN5reCy79
         ge/41Vf3C+ncKxsJPmc+L0//obtKM2SEuexZGKYKQytS/r7drtu3+f/2UoQq6owynhoP
         MyuXrt7w2G3dVu1MhMXjfyDytNlTFFQWsYFSSfSzGjSLHDRQGbDdjg+xZROwCiiBiLeD
         vqAw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=H1WH+m4HtI2EGHXBWwRjqqQ+z0hMsWiIPo2ajT3gcbE=;
        b=AP81//eNPHLQAPrQRNEvXL+zWtC0tGTMaWWTpUiT1MgsxVf1P0IuBj3NcU99Rt0UJ6
         D+jrQevtP7mnXf4OgZm3VkSXayeXs9IytzBKz7IwM0N1UruWIfj6QAwUDR7yrz6JYbrr
         m+dwiOmecL4CKJo9Jdg/1fuFi3e8DpA3B0i8OcpgJcHjRg/LZrFmJY2t1QOWaN+IMo/C
         f1F/LWEf0EOHjl9jDbv5YV+5ytR0N2Mq8GpqPJmlGPWyAD+Uw9ba8VXKD/LGrJ0p1HDH
         dvPZ8AFB0ievx+jOyLRpz7r3G5rpJPqiGWDp5oFzKJfzpUVNuAvSj85RTN81i/mWySk1
         tAgA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=WojcGWlL;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id h27si5458283ejd.96.2020.08.31.15.53.28;
        Mon, 31 Aug 2020 15:53:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=WojcGWlL;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728648AbgHaUhe (ORCPT <rfc822;learnos2017@gmail.com>
        + 99 others); Mon, 31 Aug 2020 16:37:34 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:19271 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726167AbgHaUhd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Aug 2020 16:37:33 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f4d5f7e0005>; Mon, 31 Aug 2020 13:37:18 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 31 Aug 2020 13:37:32 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 31 Aug 2020 13:37:32 -0700
Received: from [10.2.173.243] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 31 Aug
 2020 20:37:31 +0000
Subject: Re: [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and
 supplies to required properties
To:     Sakari Ailus <sakari.ailus@iki.fi>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <hverkuil@xs4all.nl>, <luca@lucaceresoli.net>,
        <leonl@leopardimaging.com>, <robh+dt@kernel.org>,
        <lgirdwood@gmail.com>, <broonie@kernel.org>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1598903558-9691-1-git-send-email-skomatineni@nvidia.com>
 <1598903558-9691-4-git-send-email-skomatineni@nvidia.com>
 <20200831201757.GC844@valkosipuli.retiisi.org.uk>
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
Message-ID: <5c341ed9-6077-e935-de50-ff9f5f17edcf@nvidia.com>
Date:   Mon, 31 Aug 2020 13:37:21 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200831201757.GC844@valkosipuli.retiisi.org.uk>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1598906238; bh=H1WH+m4HtI2EGHXBWwRjqqQ+z0hMsWiIPo2ajT3gcbE=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=WojcGWlL0gJPIaerKq14GWOlTI6hEKPE7hOSVI16rTPCBz853XZLSJwbodlvTOyAA
         B4JUVKeLKd1elrlCvVGI1NpAtQoUOAAbdLzwLkf39tjSQHWhdhtDjTFsKOttS2tGeF
         dTjKUyD9UCLCrSWZush3W6vcN/bncG+JMPYJQW0Z0/+ZRdavBw6LIdhEGARwpL0kap
         R/Pd6M5ZOdIAnnu9gop7tDgiwwAKNPSserDMrrI0UNJntMIp+ZEtbhGOtBQC4DynWp
         JPdP/Nf/NuhjI/4oXgLPrW0I1YQL8skv/3AkeU/cGdE3QecHfAYZ18HiRlSLZZJ51d
         JkGZM8HDE25IA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/31/20 1:17 PM, Sakari Ailus wrote:
> Hi Sowjanya,
>
> On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote:
>> Clock and supplies are external to IMX274 sensor and are dependent
>> on camera module design.
>>
>> So, this patch moves them to required properties.
>>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>>   Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> index d0a5c899..b43bed6 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>> @@ -10,15 +10,15 @@ at 1440 Mbps.
>>   Required Properties:
>>   - compatible: value should be "sony,imx274" for imx274 sensor
>>   - reg: I2C bus address of the device
>> -
>> -Optional Properties:
>> -- reset-gpios: Sensor reset GPIO
>>   - clocks: Reference to the input clock.
>>   - clock-names: Should be "inck".
>>   - vana-supply: Sensor 2.8v analog supply.
>>   - vdig-supply: Sensor 1.8v digital core supply.
>>   - vddl-supply: Sensor digital IO 1.2v supply.
> If these have been optional in the past I don't think we can start
> requiring them now.
>
> The framework will just give the driver a dummy regulator if one isn't
> found.
These were added recently with my patches. So I hope should be ok to 
make them required as they are external to sensor
>
>>   
>> +Optional Properties:
>> +- reset-gpios: Sensor reset GPIO
>> +
>>   The imx274 device node should contain one 'port' child node with
>>   an 'endpoint' subnode. For further reading on port node refer to
>>   Documentation/devicetree/bindings/media/video-interfaces.txt.