Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1307332pxk;
        Mon, 31 Aug 2020 15:57:25 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwIYclKhWcTXlxODKwC0+Tao74Qbyn2fi4VXAu66Qx4Gd9PtrmjVGpY8eV9biCJ8KNLN51+
X-Received: by 2002:a17:907:9c3:: with SMTP id bx3mr3054968ejc.164.1598914644882;
        Mon, 31 Aug 2020 15:57:24 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598914644; cv=none;
        d=google.com; s=arc-20160816;
        b=o9bXe4nJs8ni2K4UDygWzy6B6h5x4HcN361jDynsJ3GcrYXFn+x1IBtaxuIml01Rr4
         nQ8ycmOb7iTpYQfWEcvd2TT29nIc9+Y+Zhu/dkDJt90WFY4JqyzFrtrBRbu5v5G/eKAS
         9iNLzSDxzHxTxrlGs5sNMxg1P4/zirgG3sHc4sigR3Cj8RfrjDuvCIayL3f/VzaB2BKV
         6AcSVnDoWi8f3PlxgP40LNgxqEKXE6uLZOnWOxoJUqhijLRs0ClWn8Di2CxLVL/a6EK+
         MVp2IE22vswCTPNhEIzIa4DVgxqlTj9NHO0ZFRajB/tmPNreaq/S++GQquQDiuzT4njD
         k+pw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:references:cc:to:from:subject;
        bh=0PRiVPO6ujz6K0EzzICGEoJlqFT3wY1llIkCkcKabOk=;
        b=lY94j9L1VevlN5zIsjmDBT3KHVLi+4kHgFQxmcH8eeRCL11pbmzycMh9+tJecAY8xp
         /F6Fj09yjXVEaNcQYrSOS6OM5pgn34Q9h9mECIOPNgDqu+OKBV9vWdsgZAx6xs7lDIkG
         J+ACY34m4xRD137Dd87/j2OfTMq1UQV9fjjC7ejFHa1orpapWUbpF4dHgwLN8icF7CHV
         msSbUKT0laRIuQnL+lThaaaohd25zxHHc9bwZ3RTqgMs5eSZZq6LXw21plSCDzEb7Vfp
         8dzpYNZPyKnNgBIvxBxCVHYrb5de78wSTCCADenwwmGL8tzG8SF89nvqszVVgqon/APf
         xt2A==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=dNu0FNMq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id t2si6606710edf.426.2020.08.31.15.57.02;
        Mon, 31 Aug 2020 15:57:24 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=dNu0FNMq;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728685AbgHaUlO (ORCPT <rfc822;learnos2017@gmail.com>
        + 99 others); Mon, 31 Aug 2020 16:41:14 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:19703 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726102AbgHaUlN (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 31 Aug 2020 16:41:13 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f4d605b0000>; Mon, 31 Aug 2020 13:40:59 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Mon, 31 Aug 2020 13:41:13 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Mon, 31 Aug 2020 13:41:13 -0700
Received: from [10.2.173.243] (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 31 Aug
 2020 20:41:12 +0000
Subject: Re: [PATCH v4 3/4] dt-bindings: media: imx274: Move clock and
 supplies to required properties
From:   Sowjanya Komatineni <skomatineni@nvidia.com>
To:     Sakari Ailus <sakari.ailus@iki.fi>
CC:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <hverkuil@xs4all.nl>, <luca@lucaceresoli.net>,
        <leonl@leopardimaging.com>, <robh+dt@kernel.org>,
        <lgirdwood@gmail.com>, <broonie@kernel.org>,
        <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1598903558-9691-1-git-send-email-skomatineni@nvidia.com>
 <1598903558-9691-4-git-send-email-skomatineni@nvidia.com>
 <20200831201757.GC844@valkosipuli.retiisi.org.uk>
 <5c341ed9-6077-e935-de50-ff9f5f17edcf@nvidia.com>
Message-ID: <e0fe49a4-f52c-91d7-bdbf-e0026f61a432@nvidia.com>
Date:   Mon, 31 Aug 2020 13:41:02 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <5c341ed9-6077-e935-de50-ff9f5f17edcf@nvidia.com>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1598906459; bh=0PRiVPO6ujz6K0EzzICGEoJlqFT3wY1llIkCkcKabOk=;
        h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding:
         Content-Language;
        b=dNu0FNMqGvwUxuU+6smkqkTH9slTE+L6FiUt7uqfL9s2SF8FDel9KUAWOA16elrVz
         FdBTNMRklx+1sEZ56LfN9mIJh6lOeIJAAw752zyk4mLEkWu2vEE1yWKd1b+fG+QKPD
         g3zEV9vDTWlE5wOYeOIKVhtYqCVo/j33vhyfgpCcXrD2tn4WE9VgRovXNTLHeA3XjW
         1FhvWAaoUUW+VA1leUeQmTFUUm/Pc90ReROc5rTJkLZszOBhSfNhv63gmaOD4+r+4I
         ZdO+dnX8c1PKnt+5IHw+bwOMEp439Avb3+QbpeERK5iK+P2joQbnJEX5gLTZQkmRHj
         0jd4jGSZmfZYg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 8/31/20 1:37 PM, Sowjanya Komatineni wrote:
>
> On 8/31/20 1:17 PM, Sakari Ailus wrote:
>> Hi Sowjanya,
>>
>> On Mon, Aug 31, 2020 at 12:52:37PM -0700, Sowjanya Komatineni wrote:
>>> Clock and supplies are external to IMX274 sensor and are dependent
>>> on camera module design.
>>>
>>> So, this patch moves them to required properties.
>>>
>>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>>> ---
>>> =C2=A0 Documentation/devicetree/bindings/media/i2c/imx274.txt | 6 +++--=
-
>>> =C2=A0 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt=20
>>> b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>>> index d0a5c899..b43bed6 100644
>>> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
>>> +++ b/Documentation/devicetree/bindings/media/i2c/imx274.txt
>>> @@ -10,15 +10,15 @@ at 1440 Mbps.
>>> =C2=A0 Required Properties:
>>> =C2=A0 - compatible: value should be "sony,imx274" for imx274 sensor
>>> =C2=A0 - reg: I2C bus address of the device
>>> -
>>> -Optional Properties:
>>> -- reset-gpios: Sensor reset GPIO
>>> =C2=A0 - clocks: Reference to the input clock.
>>> =C2=A0 - clock-names: Should be "inck".
>>> =C2=A0 - vana-supply: Sensor 2.8v analog supply.
>>> =C2=A0 - vdig-supply: Sensor 1.8v digital core supply.
>>> =C2=A0 - vddl-supply: Sensor digital IO 1.2v supply.
>> If these have been optional in the past I don't think we can start
>> requiring them now.
>>
>> The framework will just give the driver a dummy regulator if one isn't
>> found.
> These were added recently with my patches. So I hope should be ok to=20
> make them required as they are external to sensor

Also made them required as they are external to sensor and also to use=20
bulk_enable/disable APIs, devm_regulator_bulk_get()

does not use OPTIONAL_GET.

>>
>>> =C2=A0 +Optional Properties:
>>> +- reset-gpios: Sensor reset GPIO
>>> +
>>> =C2=A0 The imx274 device node should contain one 'port' child node with
>>> =C2=A0 an 'endpoint' subnode. For further reading on port node refer to
>>> Documentation/devicetree/bindings/media/video-interfaces.txt.