Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rCxMbNQSKXAYSO6A8y0VWI8xbxZF9IcB99nfpyYObpkfObFkBfdUU67mZua9z7FAw57I/uzZls
 AtshgANks/2A==
IronPort-SDR: qRLDdz7C3t/RrFrPYeGs77BpNajKE8YmXvKlHIqFfXgwP68IvAjfdLNI/2xzAaGDf7k4vHzAyD
 HWOBmLI40p5Q==
Subject: Re: [PATCH v4 1/7] perf util: Create streams
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
References: <20200824233513.16930-1-yao.jin@linux.intel.com>
 <20200824233513.16930-2-yao.jin@linux.intel.com>
 <20200831135609.GE406859@krava>
From:   "Jin, Yao" <yao.jin@linux.intel.com>
Message-ID: <4cef1f08-e1c1-3227-24f2-be3108ea4d99@linux.intel.com>
Date:   Tue, 1 Sep 2020 10:26:25 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200831135609.GE406859@krava>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jiri,

On 8/31/2020 9:56 PM, Jiri Olsa wrote:
> On Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
> 
> SNIP
> 
>> +						  int nr_streams_max,
>> +						  enum stream_type type)
>> +{
>> +	struct evsel_streams *es;
>> +	int nr_evsel = evlist->core.nr_entries, ret = -1;
>> +
>> +	es = create_evsel_streams(nr_evsel, nr_streams_max);
>> +	if (!es)
>> +		return NULL;
>> +
>> +	if (type == STREAM_CALLCHAIN)
>> +		ret = evlist_init_callchain_streams(evlist, es, nr_evsel);
>> +
>> +	if (ret) {
>> +		free_evsel_streams(es, nr_evsel);
>> +		return NULL;
>> +	}
>> +
>> +	return es;
>> +}
>> diff --git a/tools/perf/util/stream.h b/tools/perf/util/stream.h
>> new file mode 100644
>> index 000000000000..a8a0172b4d13
>> --- /dev/null
>> +++ b/tools/perf/util/stream.h
>> @@ -0,0 +1,30 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +#ifndef __PERF_STREAM_H
>> +#define __PERF_STREAM_H
>> +
>> +#include "callchain.h"
>> +
>> +enum stream_type {
>> +	STREAM_NONE = 0,
>> +	STREAM_CALLCHAIN
> 
> do you plan to add more types?
> 
> jirka
> 

Thanks for looking at this patch series.

So far, no more types in plan. :)

Thanks
Jin Yao