Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drivers: reduce the param length of the line
To:     Tong Chen <tongchen@whu.edu.cn>
Cc:     nic_swsd@realtek.com, davem@davemloft.net,
        linux-kernel@vger.kernel.org
References: <20200901022811.8675-1-tongchen@whu.edu.cn>
From:   Heiner Kallweit <hkallweit1@gmail.com>
Message-ID: <2552dde8-7d2a-03f9-79cc-07dd506d8b41@gmail.com>
Date:   Tue, 1 Sep 2020 09:29:43 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200901022811.8675-1-tongchen@whu.edu.cn>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 01.09.2020 04:28, Tong Chen wrote:
> Reduce the param length of the line from 79 chars to 52 chars,
> which complies with kernel preferences.

Apart from formal issues with the patch (missing net/net-next
annotation, wrong prefix): Did you get a checkpatch warning?
Or what's the source of your assumed kernel preference?

> Signed-off-by: Tong Chen <tongchen@whu.edu.cn>
> ---
>  drivers/net/ethernet/realtek/r8169_phy_config.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c
> index 913d030d73eb..f4b738cf8ad7 100644
> --- a/drivers/net/ethernet/realtek/r8169_phy_config.c
> +++ b/drivers/net/ethernet/realtek/r8169_phy_config.c
> @@ -1302,7 +1302,8 @@ static void rtl8125b_hw_phy_config(struct rtl8169_private *tp,
>  	rtl8125b_config_eee_phy(phydev);
>  }
>  
> -void r8169_hw_phy_config(struct rtl8169_private *tp, struct phy_device *phydev,
> +void r8169_hw_phy_config(struct rtl8169_private *tp,
> +			 struct phy_device *phydev,
>  			 enum mac_version ver)
>  {
>  	static const rtl_phy_cfg_fct phy_configs[] = {
>