Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1577364pxk; Tue, 1 Sep 2020 02:12:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVjVNJe0Q8IAnkrFvH0Yk21ej3NH8JxHp/fHq7fMuBHL9RGJluIGa1sMN6bdURXi+oDA3C X-Received: by 2002:a17:906:6bc9:: with SMTP id t9mr586157ejs.491.1598951535075; Tue, 01 Sep 2020 02:12:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598951535; cv=none; d=google.com; s=arc-20160816; b=LM3KvFXedv+QTO11ZD+/l3UYrgwRuLlJ0UCiNnf5sdTgizvlvvvOl8gAog9oArIy7Y Y8XaPkCzzgSjLUbQTnZ92uHMBU0zek6Ln4G8uM7TKtSLy2CqMq5xbraqL0Yte1f974SE mkWDhIrJWE7op9Q2c1OVHGA/yjR2DpENKjnfNZ+Oyd53yXY5SMv24OhA4AwBN/TPKMTD HDkn8+tBV9DHtMuMSsVRGq66QAfbGkPqfOD/Myhwusqyi8O3oqVIq4iW1MoRNxJQURi4 TB6w/f72aJ05wbkr/MX7pJPcPmUixNq2SfFxsKk+rFkBJK8Iw/4CWlN+skrSX6gOVOXc 2nJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=r27uhtHP+FtcoBysrJoR5+WF3ILL3QF+y0+lVoSe/T4=; b=mkqPivAntoX+a5VaUR/cEWl7YRcB/oTDGJaQn1zBUEqKBqw8d6bGGq4GByQVvcczQp w3ezs4L9vJ5T4pUlG5KVrX6pzM0KaxBoCQgpenFSA2Tio6FRM9Z3dPaLdQRM4mM8A3yf I6cgZ9ctqUpeMZhtPeNJtjH6xPMz5Dzoy7H4OYVTfnvkwbr81UwEFCGe7KtJtqAKQiqq MudEwky9fUuKkeD2LWYRrBpwnrmxKV5aj2DzLGqPfspVsklWGzONvBy8FG2tcLCZscYE zb0d9Ifs36KUpaMpJirWRYd5fE4SrBBYHUG+FPppo0tGvsigJc5mlXLypV1i8L62yv7G oUoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v7si279582edd.551.2020.09.01.02.11.52; Tue, 01 Sep 2020 02:12:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726400AbgIAJLL (ORCPT + 99 others); Tue, 1 Sep 2020 05:11:11 -0400 Received: from verein.lst.de ([213.95.11.211]:52607 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbgIAJLK (ORCPT ); Tue, 1 Sep 2020 05:11:10 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 5724168B05; Tue, 1 Sep 2020 11:11:05 +0200 (CEST) Date: Tue, 1 Sep 2020 11:11:05 +0200 From: Christoph Hellwig To: Nicolin Chen Cc: Christoph Hellwig , mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, tony.luck@intel.com, fenghua.yu@intel.com, schnelle@linux.ibm.com, gerald.schaefer@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, davem@davemloft.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, sfr@canb.auug.org.au, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-parisc@vger.kernel.org Subject: Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size Message-ID: <20200901091105.GA4959@lst.de> References: <20200831203811.8494-1-nicoleotsuka@gmail.com> <20200901073623.GA30418@lst.de> <20200901075401.GA5667@Asurada-Nvidia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901075401.GA5667@Asurada-Nvidia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2020 at 12:54:01AM -0700, Nicolin Chen wrote: > Hi Christoph, > > On Tue, Sep 01, 2020 at 09:36:23AM +0200, Christoph Hellwig wrote: > > I really don't like all the open coded smarts in the various drivers. > > What do you think about a helper like the one in the untested patch > > A helper function will be actually better. I was thinking of > one yet not very sure about the naming and where to put it. > > > below (on top of your series). Also please include the original > > segment boundary patch with the next resend so that the series has > > the full context. > > I will use your change instead and resend with the ULONG_MAX > change. But in that case, should I make separate changes for > different files like this series, or just one single change > like yours? > > Asking this as I was expecting that those changes would get > applied by different maintainers. But now it feels like you > will merge it to your tree at once? I guess one patch is fine. I can queue it up in the dma-mapping tree as a prep patch for the default boundary change.