Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1598441840-15226-1-git-send-email-gene.chen.richtek@gmail.com>
 <1598441840-15226-2-git-send-email-gene.chen.richtek@gmail.com> <f35bf9c1-6397-3369-954d-fe05d77438cd@infradead.org>
In-Reply-To: <f35bf9c1-6397-3369-954d-fe05d77438cd@infradead.org>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Tue, 1 Sep 2020 20:29:37 +0800
Message-ID: <CAE+NS36MAwNJkbNV30h=bjB6UnW8u9XuzNkDB4Nor=x63Oz3Eg@mail.gmail.com>
Subject: Re: [PATCH 1/2] leds: mt6360: Add LED driver for MT6360
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     jacek.anaszewski@gmail.com, pavel@ucw.cz,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
        Gene Chen <gene_chen@richtek.com>, Wilma.Wu@mediatek.com,
        shufan_lee@richtek.com, cy_huang@richtek.com,
        benjamin.chao@mediatek.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Randy Dunlap <rdunlap@infradead.org> =E6=96=BC 2020=E5=B9=B48=E6=9C=8826=E6=
=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=8811:30=E5=AF=AB=E9=81=93=EF=BC=
=9A
>
> On 8/26/20 4:37 AM, Gene Chen wrote:
> > diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> > index 1c181df..ce95ead 100644
> > --- a/drivers/leds/Kconfig
> > +++ b/drivers/leds/Kconfig
> > @@ -271,6 +271,17 @@ config LEDS_MT6323
> >         This option enables support for on-chip LED drivers found on
> >         Mediatek MT6323 PMIC.
> >
> > +config LEDS_MT6360
> > +     tristate "LED Support for Mediatek MT6360 PMIC"
> > +     depends on LEDS_CLASS_FLASH && OF
> > +     depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
> > +     depends on MFD_MT6360
> > +     help
> > +       This option enables support for dual Flash LED drivers found on
> > +       Mediatek MT6360 PMIC.
> > +       Support Torch and Strobe mode independently current source.
>
>           Supports                      independently of current source.
>
> I'm guessing on that ending; I wasn't sure what was intended, but it does=
n't
> make sense as posted.
>
>

I want to say is fled1/2 can independently control.
For example, fled1 in strobe mode, or fled2 in torch mode,
or both fled1 and fled2 in torch or strobe mode

> > +       Include Low-VF and short protection.
>
>           Includes
>

ACK

> > +
> >  config LEDS_S3C24XX
> >       tristate "LED Support for Samsung S3C24XX GPIO LEDs"
> >       depends on LEDS_CLASS
>
>
> thanks.
> --
> ~Randy