Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1719008pxk; Tue, 1 Sep 2020 06:16:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBORvfBJ5FQijV7wVP44OqBEa7yvt+sr8aTREqPrXXM7yao+6VLKaWsMR+oaOba/unQOz+ X-Received: by 2002:a17:907:2078:: with SMTP id qp24mr1425956ejb.286.1598966207101; Tue, 01 Sep 2020 06:16:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598966207; cv=none; d=google.com; s=arc-20160816; b=A9ZfSd/fC26BqI3KNb3d8vhg3TOV6aZ9RMDv2yl4MPDNN55de2xz5JkqT0z7fN9CBh xswvDM+Kx4npclJlIOugvndM0vKPc5x27CSLSOhNP5TTIirBMxLf+NQbFy9fRj7N7/We uI9vBwS3Yi5bCP1rnV/2GgF4vdu/rzvDFCG0qJyhHt+MGMIsh38ZdHC272/Q0kGpwjgM /aG4dJWxKbbwk6HVBk/RizlYwjc3uOTynmYKMd0uo8lMxG92H1MKn9otB53Ov0PBEitI esTyNcCMCFE2JQW2698jT7pyLl0QMya2Yi835cTIv+dIevxLob0JqqvKZJktAFON4JgG OASA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:dkim-signature; bh=XM/YiO1AN+GvGSxUyxQbpOxOSqb3rPJ2qUV4jnebMHM=; b=eWbmCTqo19y0smAS7QcM5Aj+/mkukfBSl5Y6Ey4Tff1DZbscTvQMQlsA2jhXh67ZhP Sx6qrXCIvTeiV3QXwJf2Q+yiK9+EQDuPqGrnRXwo+Wy1mU7mt4AdkyUGsLSxaN2Wwnvd zdEaSjQrQsCdfjBjw6n7OBxPXRKdguC25WBrKy72422U2tvUPVuHUepcToC1YM09QksI 5DBNA9Jvz2oCpjV8nrQixGnmmzWc1J/AwkXiPJPE9N7sgKjlsQykZWlTjhcm+j6gDsDE BcGF1bejUDnTKfkYNWgtmi6dBiepU94zUM5NmmaLXqKIBP25tIM1u1diQQhHccho5dsn lHnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=aCznlRUI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m1si615229ejj.381.2020.09.01.06.16.23; Tue, 01 Sep 2020 06:16:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=aCznlRUI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728115AbgIANLY (ORCPT + 99 others); Tue, 1 Sep 2020 09:11:24 -0400 Received: from smtp2.axis.com ([195.60.68.18]:45874 "EHLO smtp2.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727910AbgIANIR (ORCPT ); Tue, 1 Sep 2020 09:08:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; l=1083; q=dns/txt; s=axis-central1; t=1598965698; x=1630501698; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=XM/YiO1AN+GvGSxUyxQbpOxOSqb3rPJ2qUV4jnebMHM=; b=aCznlRUIkbKvI3sryWZwlM5RabuvRLWGJqu1ojNNGX4J20qFDwYIYtYL txGIHYrol5zhwIq1jM2wMIZUsllRq8sIzwnAgW82lNYpCuyQQ85auakJO 6A+szlrAu1cx7U/5M6ncMTtomd4ehdxxbc1wMoX/H+2VrO2Zmj1uAMjxx NCL3PDn73gE6wIvr2Nh68H+zIrp4NcGYMzsHu+AjNGpGWS8lkWaVZcHEj K6Q3JNgZ3WgWc1tHdwd8c/1CK9EMlKHhxyzFu/LxIeJCwIqb7gIvWbjUm X3/UNxscOSWxfdHM/iB5axVOtwlYUHwBhCEeoILoLJJKwj7p0yXCEVEsX Q==; IronPort-SDR: urVlRcHZRIGbnH4AspnR2uVOcG06TA9Z0n8XexRq5uYKEEPHYbwJGmrq0Ioo5lxoG/KKgmyqo6 BsjAEXKDGc8CFYzk/FNoVYj+qxJBhf8xeh/FF9+VLrER3BrxNJRlyPgscEIMY9cW9sSQTnWS+0 0esfg9GrMu8aRpsgsUcc/lsVmNCooNQ+FwKZxVSkn2RK1qXs5VQZ/vASoOJK5w/gFCsWOc4Fi/ e2970Rqug8IDPYt4/2Ns4Uv0cuRuuHVKJS1l9hTEktJJZJCgAuoOVmt6kbyn1OCNehCyMewJ07 peE= X-IronPort-AV: E=Sophos;i="5.76,379,1592863200"; d="scan'208";a="12085624" From: Camel Guo To: , , , , CC: , , , Camel Guo , Camel Guo Subject: [PATCH v3] ASoC: tlv320adcx140: Fix accessing uninitialized adcx140->dev Date: Tue, 1 Sep 2020 15:07:52 +0200 Message-ID: <20200901130753.27670-1-camel.guo@axis.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Camel Guo In adcx140_i2c_probe, adcx140->dev is accessed before its initialization. This commit fixes this bug. Fixes: 689c7655b50c ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family") Signed-off-by: Camel Guo --- sound/soc/codecs/tlv320adcx140.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c index 5cd50d841177..7ae6ec374be3 100644 --- a/sound/soc/codecs/tlv320adcx140.c +++ b/sound/soc/codecs/tlv320adcx140.c @@ -980,6 +980,8 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, if (!adcx140) return -ENOMEM; + adcx140->dev = &i2c->dev; + adcx140->gpio_reset = devm_gpiod_get_optional(adcx140->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(adcx140->gpio_reset)) @@ -1007,7 +1009,7 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, ret); return ret; } - adcx140->dev = &i2c->dev; + i2c_set_clientdata(i2c, adcx140); return devm_snd_soc_register_component(&i2c->dev, -- 2.20.1