Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1727869pxk; Tue, 1 Sep 2020 06:28:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzj/0azr9XE7wJeVgqHEouSUZUKs0QhRsnab+T3kzG/fi6iNVrNhcloJGdOAK/44Tc39KeB X-Received: by 2002:a17:906:390d:: with SMTP id f13mr1445032eje.86.1598966923841; Tue, 01 Sep 2020 06:28:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598966923; cv=none; d=google.com; s=arc-20160816; b=ra2Jo9F4e8AdYnmVEie4yTwrU3ypE6qbEfrtksVu4ElL82hYihRnsglCGfE+SX75wY z81dfjshTST50T/+kugDhtewlQRcHrlwkLs474io0p5jtAUzARbZFkf5mqRFftAm9Vas 115fBWY1TPk5es8cIchtIEAP0Un+GK5uF2LsyUj7BKuxG2NrkA87YCdkt3KqHm0Fnq9v bHoJXoZ1G3HXyqTe2gLPIlqLDDs2NdxaHXFfRY+CcXCJd/fHtfmCrISaEmKwqmFMNgl6 rDulK0/geWzcXo0LifyKGigNv2b/GFNCpF90AXCdPmAPNbXcdgKCxwIWSnY5vtwLyYng n6Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=9uW7HqUpxdzqV40dT/tamC4W2czgW8JE3IFLKMzq3Eo=; b=FJ4Uh/kpDE9o63lbX0Wncigxbaz3wW01DUjmBV1MuL9GknwEO5x7gqZ+e2TPLXP5Tz F71s+GeIpojA4L59CsTj3fs9rUXvWCKaMBOUjH3jDxat8dCaDOvAHQtg+mXB0aqPT3VI T24hpSziXeODW/z54kxcIzk7/Su2LgHt9aj8EL8piSxsuxWDClOCopMDvM1kKxeL8Bis JF+oK7MryzzE+633Kue6uL2fgBv1CosVrjI5MLZI/x1ridIFK6iSO0VgCLPLxFX+mzMb Gv5GT1XHE+RtwIykklGhIeQ/Qg88TB6P9+/8pMTr6iUKHXNROYsms+Lp7q0VpPEI9VvH 24uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=brOl6QMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j10si578727edt.534.2020.09.01.06.28.19; Tue, 01 Sep 2020 06:28:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=brOl6QMQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727906AbgIAN1E (ORCPT + 99 others); Tue, 1 Sep 2020 09:27:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727937AbgIANSl (ORCPT ); Tue, 1 Sep 2020 09:18:41 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A004AC061244 for ; Tue, 1 Sep 2020 06:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9uW7HqUpxdzqV40dT/tamC4W2czgW8JE3IFLKMzq3Eo=; b=brOl6QMQuceus0POSkNwRKBOPc a4W5E4fFl7mLou9iwqiW83OOIPD5tloQdE1hL+3dHtn3KeDWt1WiK/amSqHISq0Ms6iR6KD+ijhX1 9pD/BauzyKChN3tT8YoEAhpVb3nFR1j1Xdj247X9Jk8/yn+AlnpZ+6CGwTAR4yUSM6qXC2Uh7KuFx 0jSgoTqBKhEA1eCqArL9i2lvKkEx6/NcG6KBFZZ6HvoaHI0oy+GXHXokOG0RopsEGzAzz7N3jz57I 3+HG3RbBSp9JJ9QZLfwWv95iRlJhKcuZrEEIAmLPBos5B/+SSld/kA0mMpTtIQmbe7o2hkcq3QQi8 1UYGo03w==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kD6AX-0000v5-Gv; Tue, 01 Sep 2020 13:17:49 +0000 Date: Tue, 1 Sep 2020 14:17:49 +0100 From: Matthew Wilcox To: Alex Shi Cc: Anshuman Khandual , David Hildenbrand , Andrew Morton , Baolin Wang , Russell King , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/3] mm/armv6: work around armv6 cmpxchg support issue Message-ID: <20200901131749.GL14765@casper.infradead.org> References: <1598928612-68996-1-git-send-email-alex.shi@linux.alibaba.com> <1598928612-68996-3-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2020 at 02:30:51PM +0800, Alex Shi wrote: > seems there are couples archs can not do cmpxchg1 > So update the patch here. And it's easy to fix if more arch issue find here. > +/* > + * cmpxchg only support 32-bits operands on the following archs ARMv6, SPARC32 > + * sh2, XTENSA. > + */ > +#if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_SH2) || \ > + defined(CONFIG_SPARC32) || defined(CONFIG_XTENSA) Looks like we need a HAVE_CMPXCHG_BYTE in Kconfig to parallel HAVE_CMPXCHG_DOUBLE.