Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1751754pxk; Tue, 1 Sep 2020 07:02:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyWFIHIgrbs4hzuOfE3ZJ3HZ3MYcz389kX//kKbrDMeNGhmfku2gNppArzh+igrV9p67wmW X-Received: by 2002:a17:906:130a:: with SMTP id w10mr1556010ejb.106.1598968955780; Tue, 01 Sep 2020 07:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598968955; cv=none; d=google.com; s=arc-20160816; b=ERL6+Edabu9HaKVHgE61vXJ58DG0LAu9CycxZTGA0bHRp1z6BH3YplKzmvnpCNsP5s IGuZytN3KroBACdgi1Gnn5J87a9aA6XSxEv6Rkj7FGY5yV90JvIVNl7w5hN70HgCVIm3 p6MOq2VP1M3Alw74iGWOSCqm5TawDFisbl7Bc/E6gjs2uS1A2Ay+pz5A+3XDfEpbrkd2 zatN/7Qaucwy5X5tI81i1+bPiOo7DxsN2SN5wz9fl0T+LxoF5vED3w19G2cSTVw13Tvu VN9OdoyGOeDQCV/zoKHMv0d1OYFTD5d2wE98QW+8psoUu89IICHNQlQI7/L4BwBDu8IN 9COg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=NHTaRYYp4coKtv65WtK5Af+zvK1PQU9/g9YdEyrLhJM=; b=caJDE9SeVnQ5VD3P9X9+Em2vHLXk0sHMADjr8wSCsIOXRWWHAyEFMS59rPWipZAkWH 9tNZGc3jX6ikxYStivcMliAI91ETHq1ggZ7fIMhDpXn75dKhVf8ZJcAxBep/nZDIEUXk nWH2RQMQVmvrU5U/PB0BUWaKnga85LJGJKMCxiZIXqyrL+ELMdScwXj2f5YAvqG+K+R6 fk3345v0YUrMU6O+0H9hvqBx7tJhjncx5nodwA4y47nliS/gLPgUYR74J9pyrLLC7COl QsdIzF7XOJ11ejDP3Nz+f8Sv4A2YDh+j4R1/3uXXsNsHnh7zrxV3inxdD3inyQikBSA1 8Fvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h6si712412ejc.567.2020.09.01.07.02.12; Tue, 01 Sep 2020 07:02:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728306AbgIAOAk (ORCPT + 99 others); Tue, 1 Sep 2020 10:00:40 -0400 Received: from elvis.franken.de ([193.175.24.41]:45709 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728294AbgIANzc (ORCPT ); Tue, 1 Sep 2020 09:55:32 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1kD6kf-0001nf-02; Tue, 01 Sep 2020 15:55:09 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 62CB0C0E4C; Tue, 1 Sep 2020 15:53:04 +0200 (CEST) Date: Tue, 1 Sep 2020 15:53:04 +0200 From: Thomas Bogendoerfer To: Christoph Hellwig Cc: Mauro Carvalho Chehab , "James E.J. Bottomley" , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Ben Skeggs , Pawel Osciak , Marek Szyprowski , Matt Porter , iommu@lists.linux-foundation.org, Tom Lendacky , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-samsung-soc@vger.kernel.org, nouveau@lists.freedesktop.org, netdev@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: Re: [PATCH 08/28] MIPS: make dma_sync_*_for_cpu a little less overzealous Message-ID: <20200901135304.GC11944@alpha.franken.de> References: <20200819065555.1802761-1-hch@lst.de> <20200819065555.1802761-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819065555.1802761-9-hch@lst.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 19, 2020 at 08:55:35AM +0200, Christoph Hellwig wrote: > When transferring DMA ownership back to the CPU there should never > be any writeback from the cache, as the buffer was owned by the > device until now. Instead it should just be invalidated for the > mapping directions where the device could have written data. > Note that the changes rely on the fact that kmap_atomic is stubbed > out for the !HIGHMEM case to simplify the code a bit. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/mm/dma-noncoherent.c | 44 +++++++++++++++++++++------------- > 1 file changed, 28 insertions(+), 16 deletions(-) Acked-by: Thomas Bogendoerfer -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]