Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1810004pxk;
        Tue, 1 Sep 2020 08:18:57 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyOgff+rYoP++nY/cumRV2xpHG3yvGP+Us4q/gbMqtjUah5mNysENCI0/GMFl5MAZV2SvvL
X-Received: by 2002:aa7:d3c2:: with SMTP id o2mr2163331edr.11.1598973537217;
        Tue, 01 Sep 2020 08:18:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1598973537; cv=none;
        d=google.com; s=arc-20160816;
        b=mRiOJSyHaX4sO7UD9LwgZ4KVS6OFLXl6BJldU0/lXeJ+rHDwB57LvH+YjMX8ayCB8s
         0L9Lxz8hgl/0GKim++CDpy5xnBM11ZhwjjAePLiX94At0LksRXw+2s+kY6IEtLmhYr9X
         +3SEOHF0DVxqASu4QGxrf7Uod/S/LwnycjbLxtvLmnGTv/7OD4onxYdGrnK50AKmKD7f
         qZ1JMa9SywvS2SUMwZRY6l4WQXYOSh8lF0oeoLYmKzHhHydbChV/2nKkFC5H7dfbukac
         YZKSUbiCRzG544xtrlFGDTmXmkZI+Vauo498Oad3U45S3ftS+pMmCQQ2p1e2aH5ELcRP
         kxCw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=0Zwi/5IDkukNC2BMrNnYqnzbnVh0Tpwe8JHQnlQllUI=;
        b=XXyBq+zmLdYGvy99evdUdw+Tw0cZOt7zSpC5rwox6jJ3sZMI+Kmzx7MDh9V618y2ah
         WralSCqlrSiFfPMJVcJgIqbkXYbfHcT9A6HViCK94SgMginGPMzzUVTYITZ76l71xY99
         tN70smyF37GV7cxbUnA15kE3I+/ST7y042sFvCwL3GugZFRmNshtVDGCrDOr42J5bcy+
         7RF//qc68CodaI92eI6/wT4PghO963GVt4Jy7ccamdtAnLN0mAMQQp/Xj1z0pEmMdPkP
         DfVe0yxiV8ljQTBIHuEy0AfBO92Z8h89oCVMwKYDcKCQbeE2VeGyTAdsTR89umMWdNil
         BSdw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p60si725171edd.302.2020.09.01.08.18.33;
        Tue, 01 Sep 2020 08:18:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1729325AbgIAPQo (ORCPT <rfc822;kerneldev.sdk@gmail.com>
        + 99 others); Tue, 1 Sep 2020 11:16:44 -0400
Received: from verein.lst.de ([213.95.11.211]:53795 "EHLO verein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1729248AbgIAPP6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Sep 2020 11:15:58 -0400
Received: by verein.lst.de (Postfix, from userid 2407)
        id 498D768CEC; Tue,  1 Sep 2020 17:15:56 +0200 (CEST)
Date:   Tue, 1 Sep 2020 17:15:55 +0200
From:   Christoph Hellwig <hch@lst.de>
To:     Josef Bacik <josef@toxicpanda.com>
Cc:     hch@lst.de, viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, willy@infradead.org,
        kernel-team@fb.com
Subject: Re: [PATCH 6/6] sunrpc: rework proc handlers to take advantage of
 the new buffer
Message-ID: <20200901151555.GF30709@lst.de>
References: <20200813210411.905010-1-josef@toxicpanda.com> <20200813210411.905010-7-josef@toxicpanda.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200813210411.905010-7-josef@toxicpanda.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 13, 2020 at 05:04:11PM -0400, Josef Bacik wrote:
> +		len = scnprintf(buffer, *lenp, "0x%04x\n", *(unsigned int *) table->data);

This adds a really hard to read overlong long line.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>