Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1872728pxk; Tue, 1 Sep 2020 09:42:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz90NgTBK1EWlMjd62jv/MZQ1ts5JrLP/3D6fbuoQUqDjnco+ZHC8g5n9nzUNNlGb/4+mVB X-Received: by 2002:a17:906:c18d:: with SMTP id g13mr2214106ejz.239.1598978577454; Tue, 01 Sep 2020 09:42:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598978577; cv=none; d=google.com; s=arc-20160816; b=UcRX54sp9O0elLJx6X0nmZc6yu5dDa7RNmAKi1ig1CtUpOzd/3o4RJDLY4GYUGECQA w/ytGNxhmwbIq0M6hYo1pBGA5z/g7tpWUtnamceA/735Tvtrhs1FpkRVLUbhDzyur4Q7 aFCP6/SKuB1xDcwOCFvKmAQEFmNhKwA+RI8U3bDMT3O+5aJdE9WK5MxtTVhhPsUhbp4U ZqDvswFyYlOltLpd18pKQuKsUYyLM7n3bLwHug+dT7ZIppLbkNsntC3NteNBbieag2IB nJpFGkaFP437j20RIFzM2FLj6W9hCOKkY4gOejnMko70SD/6QsGvy/t8YYtYmPda7ENx B+Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=DwgZSgKtP6guKuHkjZzjGqU9MkKfJM2Et9KkuRO0zHU=; b=uuTCJLTpKfFMTgsqWh+qTcc1DIOLQmPm6LjRT7it4yVAspDXR8iS3g24mbSoLkfr4a TC6TUxKJJdmxehqrVcgBA5I4ZvPUCP+VPWgE3v8efpPLLLg1JbB5fSzMZQ73Fn7qoZim FFIH1eG5+G68859hQQchbUGjUDNl2T2hBOxYGzDsKl6W3d5QclVpUGa+UM7T8sfKW7Rt mfZxBcGLruYXtUoAblxWVURYEtzQsqE1zWZr8zASCl+i0R0lHZ7Z+booNv5hcrumzYvv 969Xdfe/RIMKU8iZ5//Q/51dUeAMV0RmSMk/ytCe69oKRLAPfZRqVDAm1HsW06t2Vws2 nvRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WvjCz2qB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i5si921513ejx.135.2020.09.01.09.42.33; Tue, 01 Sep 2020 09:42:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=WvjCz2qB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731689AbgIAQlj (ORCPT + 99 others); Tue, 1 Sep 2020 12:41:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:36984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730413AbgIAQle (ORCPT ); Tue, 1 Sep 2020 12:41:34 -0400 Received: from gmail.com (unknown [104.132.1.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B0E5C20767; Tue, 1 Sep 2020 16:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598978493; bh=Dpj3KMcxE1VLvM7pvNMakfITVTdblxRjjMAZljRkcDU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WvjCz2qBgk+FjDtaXrxOLkuzmSpoC4TPO6NJF7n+CDvIMNWJQWf99TvOqppqIMqw8 6AhmQ6HzzYRQSIMUnBHMLF7hekb3DnxI1zqCnflew4pbnq/sR2xUas2XQNIH19JdHZ F9Syn/FXhE0QGH+nz2WFVMtNgTW0oGlziYXvCKB0= Date: Tue, 1 Sep 2020 09:41:32 -0700 From: Eric Biggers To: David Howells Cc: willy@infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/7] mm: Make more use of readahead_control Message-ID: <20200901164132.GD669796@gmail.com> References: <159897769535.405783.17587409235571100774.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159897769535.405783.17587409235571100774.stgit@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2020 at 05:28:15PM +0100, David Howells wrote: > > Hi Willy, > > Here's a set of patches to expand the use of the readahead_control struct, > essentially from do_sync_mmap_readahead() down. Note that I've been > passing the number of pages to read in rac->_nr_pages, and then saving it > and changing it certain points, e.g. page_cache_readahead_unbounded(). > > Also pass file_ra_state into force_page_cache_readahead(). > > Also there's an apparent minor bug in khugepaged.c that I've included a > patch for: page_cache_sync_readahead() looks to be given the wrong size in > collapse_file(). > What branch does this apply to? - Eric