Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1874668pxk; Tue, 1 Sep 2020 09:45:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydlWqSAiJoJdWBqRtPiBTqCeSW/8aK8lkJNyeb5g8fp2g5i67ZjUHwdHIhqDmSDJIwkkar X-Received: by 2002:a17:906:b2c3:: with SMTP id cf3mr2418827ejb.387.1598978757874; Tue, 01 Sep 2020 09:45:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598978757; cv=none; d=google.com; s=arc-20160816; b=PBt/BfZMaaIrpub7cF5T/WpRVybtMZiliOvRk/tpNpnKunuOZlSiddhtkaqMR/OIuY weedhZFr54ALSkYVuiWxe4YZN8YlJ5bOv+yrkqoEfJAddOn1twUicAReAfeMDTrbT9Qv kWVnZOgt2QgsNpoTGIAc6n8QmKwwYniP+OUHPW11TMgd2pP9WQMHDIA1+GpUPzv03DoJ a1f6W50jNzK4FXygt6HK+EZ76j5rSmZlhTlkh4gBFyLAbe//2/m6xI0AqE4WezcKNFuu 6cKdRIT2guq3binwCcywW8mjQ2+uQhF+jpCqb0bhrJVqSJUgFchSRpZMVvgOFuGD/Jzp JE5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aYHtfOZSDjunwlZQQ7y+MFu3PzzqSbWiktyLCANPp+I=; b=caWPL6pVIu2PHoXWjDIM6HfU/xLo/Lmbfr6GstjonEXquujdN2ReY763Z/xQqCvcYe BPrRYY2cYV+634e2LEZxs15kvN5IgiJ7IkZ4UNsDY6zcqnz3OhD4Sne+Mk1/li9uM05w 5bCco5gUnIuDfpTMTzILeC8eJoIwRFtXP8fAa6Bg6bmQcI9vIYocGWz1DntvOU1ru/mA tyM/Qz5eesSrtAVIXfaQwKZUiGDiMSugXQiQ9733ULwcRdlz/RCeiSn618Fw060afxUP 26OpkLEQfrgdE87YjZifIiiw7A+zMsooitCScTdkVANxjIzwFzE41tsUJyudlemo1dfw km1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uNj3VvcL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q25si841638edr.402.2020.09.01.09.45.33; Tue, 01 Sep 2020 09:45:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uNj3VvcL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729700AbgIAQpE (ORCPT + 99 others); Tue, 1 Sep 2020 12:45:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:54642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730213AbgIAP1d (ORCPT ); Tue, 1 Sep 2020 11:27:33 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BD752078B; Tue, 1 Sep 2020 15:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1598974052; bh=PBjywAkB5vZAJ4hhSMwUDs22mIJkEDd3jovDCARY+7U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uNj3VvcL5Hi5iEpGOHv8epPFF+w2I/HLOA4sL5PTSwr2vFLWJ0oyxO6ImLqba3+yw ym+oELKuBIqYpyxhdkJStgY/fR7p3PcSc9lIwgUVaDwnEfw032k+IAbypGnLrcpjA7 AF46ltWPvCJf5gvxAos9kLjMJqXAn8njpaMuGsZ0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, JiangYu , Mike Christie , Bodo Stroesser , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.4 025/214] scsi: target: tcmu: Fix crash on ARM during cmd completion Date: Tue, 1 Sep 2020 17:08:25 +0200 Message-Id: <20200901150954.179618374@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200901150952.963606936@linuxfoundation.org> References: <20200901150952.963606936@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bodo Stroesser [ Upstream commit 5a0c256d96f020e4771f6fd5524b80f89a2d3132 ] If tcmu_handle_completions() has to process a padding shorter than sizeof(struct tcmu_cmd_entry), the current call to tcmu_flush_dcache_range() with sizeof(struct tcmu_cmd_entry) as length param is wrong and causes crashes on e.g. ARM, because tcmu_flush_dcache_range() in this case calls flush_dcache_page(vmalloc_to_page(start)); with start being an invalid address above the end of the vmalloc'ed area. The fix is to use the minimum of remaining ring space and sizeof(struct tcmu_cmd_entry) as the length param. The patch was tested on kernel 4.19.118. See https://bugzilla.kernel.org/show_bug.cgi?id=208045#c10 Link: https://lore.kernel.org/r/20200629093756.8947-1-bstroesser@ts.fujitsu.com Tested-by: JiangYu Acked-by: Mike Christie Signed-off-by: Bodo Stroesser Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/target/target_core_user.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c index d766fb14942b3..8888cdf3eead9 100644 --- a/drivers/target/target_core_user.c +++ b/drivers/target/target_core_user.c @@ -1220,7 +1220,14 @@ static unsigned int tcmu_handle_completions(struct tcmu_dev *udev) struct tcmu_cmd_entry *entry = (void *) mb + CMDR_OFF + udev->cmdr_last_cleaned; - tcmu_flush_dcache_range(entry, sizeof(*entry)); + /* + * Flush max. up to end of cmd ring since current entry might + * be a padding that is shorter than sizeof(*entry) + */ + size_t ring_left = head_to_end(udev->cmdr_last_cleaned, + udev->cmdr_size); + tcmu_flush_dcache_range(entry, ring_left < sizeof(*entry) ? + ring_left : sizeof(*entry)); if (tcmu_hdr_get_op(entry->hdr.len_op) == TCMU_OP_PAD) { UPDATE_HEAD(udev->cmdr_last_cleaned, -- 2.25.1