Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Lukasz Stelmach <l.stelmach@samsung.com>
To:     Sylwester Nawrocki <snawrocki@kernel.org>
Cc:     Kukjin Kim <kgene@kernel.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Andi Shyti <andi@etezian.org>, Mark Brown <broonie@kernel.org>,
        linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        m.szyprowski@samsung.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH v2 6/9] spi: spi-s3c64xx: Check return values
Date:   Tue, 01 Sep 2020 17:21:01 +0200
In-Reply-To: <e7db038c-b8e6-8ddc-edc7-8b69c2019d04@kernel.org> (Sylwester
        Nawrocki's message of "Tue, 25 Aug 2020 21:06:10 +0200")
Message-ID: <dleftjd035tteq.fsf%l.stelmach@samsung.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-="; micalg="pgp-sha256";
        protocol="application/pgp-signature"
CMS-TYPE: 201P
References: <e7db038c-b8e6-8ddc-edc7-8b69c2019d04@kernel.org>
        <CGME20200901152113eucas1p2977046b7a5b4c5a519f88870d658698a@eucas1p2.samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

It was <2020-08-25 wto 21:06>, when Sylwester Nawrocki wrote:
> On 8/21/20 18:13, =C5=81ukasz Stelmach wrote:
>> Check return values in prepare_dma() and s3c64xx_spi_config() and
>> propagate errors upwards.
>>
>> Signed-off-by: =C5=81ukasz Stelmach<l.stelmach@samsung.com>
>> ---
>>   drivers/spi/spi-s3c64xx.c | 47 ++++++++++++++++++++++++++++++++-------
>>   1 file changed, 39 insertions(+), 8 deletions(-)
>
>> @@ -298,12 +299,24 @@ static void prepare_dma(struct s3c64xx_spi_dma_dat=
a *dma,
>>     	desc =3D dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents,
>>   				       dma->direction, DMA_PREP_INTERRUPT);
>> +	if (!desc) {
>> +		dev_err(&sdd->pdev->dev, "unable to prepare %s scatterlist",
>> +			dma->direction =3D=3D DMA_DEV_TO_MEM ? "rx" : "tx");
>> +		return -ENOMEM;
>> +	}
>>     	desc->callback =3D s3c64xx_spi_dmacb;
>>   	desc->callback_param =3D dma;
>>     	dma->cookie =3D dmaengine_submit(desc);
>> +	ret =3D dma_submit_error(dma->cookie);
>> +	if (ret) {
>> +		dev_err(&sdd->pdev->dev, "DMA submission failed");
>> +		return -EIO;
>
> Just return the error value from dma_submit_error() here?
>

=2D-8<---------------cut here---------------start------------->8---
static inline int dma_submit_error(dma_cookie_t cookie)
{
        return cookie < 0 ? cookie : 0;

}
=2D-8<---------------cut here---------------end--------------->8---

Not quite meaningful IMHO, is it?

=2D-=20
=C5=81ukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXpuyqjq9kGEVr9UQsK4enJilgBAFAl9OZt0ACgkQsK4enJil
gBBW8Qf/SHVF+tB9t6usYT5EgtkPO669b1lFpJh8qR35ZKbYw00N79FcmShNENt+
u11jWtkEVXv/6CvV84DdmPiGv8Dv/bmMq+OWSTOCyECEMSVAYmlw2vQ9I7azK7nt
FxJo7uj4E0Y3EX3bkYDOK9WU6nZZwkAzDEXCo8RdMk4vn76NL/ExSloPpIngDDvG
CI/58CKI6KewlcGIaZ5yOvDngFnHFD83iNiNC050kee2x6yETRlgxteR3Be1hR80
DYrnXDQt+lKM5C3eIUpmYpn4MVnEZRfhmNxIJDLW7tzYCgCozOC/3FEI6zCS3etc
NNv/mOvOBaKknxX1chnwkITt5ZiCVQ==
=N7L3
-----END PGP SIGNATURE-----
--=-=-=--