Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Sep 2020 19:34:05 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Arnaldo Carvalho de Melo <acme@redhat.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Al Grant <al.grant@foss.arm.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: correct SNOOPX field offset
Message-ID: <20200901173405.GI29142@worktop.programming.kicks-ass.net>
References: <9974f2d0-bf7f-518e-d9f7-4520e5ff1bb0@foss.arm.com>
 <20200825174043.GQ1509399@tassilo.jf.intel.com>
 <20200826142631.GA5351@redhat.com>
 <d68e68f5-a7c3-c276-6134-a68f068a2b80@foss.arm.com>
 <20200901150225.GA1424523@kernel.org>
 <20200901150630.GB1424523@kernel.org>
 <20200901151204.GE2674@hirez.programming.kicks-ass.net>
 <20200901155834.GC10147@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200901155834.GC10147@redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 01, 2020 at 12:58:34PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Tue, Sep 01, 2020 at 05:12:04PM +0200, peterz@infradead.org escreveu:
> > On Tue, Sep 01, 2020 at 12:06:30PM -0300, Arnaldo Carvalho de Melo wrote:
> > 
> > > Also you mixed up tools/ with include/ things, the perf part of the
> > > kernel is maintained by Ingo, PeterZ.
> > 
> > Right, it helps if the right people are on Cc.
> > 
> > > Peter, the patch is the one below, I'll collect the
> > > tools/include/uapi/linux/perf_event.h bit as it fixes the tooling,
> > > please consider taking the kernel part.
> > 
> > Al, can you resend with the right people on Cc? Also see below.
> > 
> > > ---
> > > 
> > > From:   Al Grant <al.grant@foss.arm.com>
> > > Subject: [PATCH] perf: correct SNOOPX field offset
> > > Message-ID: <9974f2d0-bf7f-518e-d9f7-4520e5ff1bb0@foss.arm.com>
> > > Date:   Mon, 24 Aug 2020 10:28:34 +0100
> > > 
> > > perf_event.h has macros that define the field offsets in the
> > > data_src bitmask in perf records. The SNOOPX and REMOTE offsets
> > > were both 37. These are distinct fields, and the bitfield layout
> > > in perf_mem_data_src confirms that SNOOPX should be at offset 38.
> > > 
> > 
> > This needs a Fixes: tag.
> 
> He provided it in a later message, here it goes:
> 
>     Fixes: 52839e653b5629bd ("perf tools: Add support for printing new mem_info encodings")
> 
> Also Andi has provided this:
> 
>     Reviewed-by: Andi Kleen <ak@linux.intel.com>

Have him send a new and complete patch, we're not an editing service.