Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   George Cherian <gcherian@marvell.com>
To:     Yang Yingliang <yangyingliang@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
CC:     "kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "arnd@arndb.de" <arnd@arndb.de>, "mst@redhat.com" <mst@redhat.com>
Subject: Re: Re: [PATCH v3] PCI: Add pci_iounmap
Thread-Topic: Re: [PATCH v3] PCI: Add pci_iounmap
Thread-Index: AdaAiO3VCaJd0VKpQqmpZfC3xBhX9w==
Date:   Tue, 1 Sep 2020 18:05:34 +0000
Message-ID: <BYAPR18MB2679AAA983C2AF3CD399ABD8C52E0@BYAPR18MB2679.namprd18.prod.outlook.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 280e0dd3-0935-482a-488b-08d84ea19f79
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2020 18:05:34.3403
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jsongXW69TcfopnoWm/srVaS1GnS1FLUo862e2uPcYzVqo1EDK0lnleYTjyptgyqOrzcGcpkFAoNiEO8ihUAsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR18MB2454
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687
 definitions=2020-09-01_10:2020-09-01,2020-09-01 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yang,

> -----Original Message-----
> From: Yang Yingliang <yangyingliang@huawei.com>
> Sent: Tuesday, September 1, 2020 6:59 PM
> To: George Cherian <gcherian@marvell.com>; linux-kernel@vger.kernel.org;
> linux-arch@vger.kernel.org; linux-pci@vger.kernel.org
> Cc: kbuild-all@lists.01.org; bhelgaas@google.com; arnd@arndb.de;
> mst@redhat.com
> Subject: Re: [PATCH v3] PCI: Add pci_iounmap
>=20
>=20
>
>=20
> On 2020/8/25 9:25, kernel test robot wrote:
> > Hi George,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on pci/next]
> > [also build test ERROR on linux/master linus/master asm-generic/master
> > v5.9-rc2 next-20200824] [If your patch is applied to the wrong git tree=
,
> kindly drop us a note.
> > And when submitting patch, we suggest to use '--base' as documented in
> > https://urldefense.proofpoint.com/v2/url?u=3Dhttps-3A__git-
> 2Dscm.com_doc
> > s_git-2Dformat-2Dpatch&d=3DDwIC-
> g&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DTjMsEFPc7di
> >
> rkF6u2D3eSIS0cA8FeYpzRkkMzr4aCbk&m=3DdvtRkwC273FmalEZE_KonLRWrIV
> WLSWfG61
> > NWTWG5LI&s=3DycW6SZOVRuKAm3YwdhyAuSh22oPuengSMVuv-
> EwaUew&e=3D ]
> >
> > url:    https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__github.com_0day-2Dci_linux_commits_George-2DCherian_PCI-2DAdd-
> 2Dpci-5Fiounmap_20200824-2D212149&d=3DDwIC-
> g&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DTjMsEFPc7dirkF6u2D3eSIS0cA8FeYpzRkk
> Mzr4aCbk&m=3DdvtRkwC273FmalEZE_KonLRWrIVWLSWfG61NWTWG5LI&s=3D6c
> UOYHeDOBZ0HaFc2z-vaDgDmbIK4LCBRt9kNkn1sto&e=3D
> > base:   https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__git.kernel.org_pub_scm_linux_kernel_git_helgaas_pci.git&d=3DDwIC-
> g&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DTjMsEFPc7dirkF6u2D3eSIS0cA8FeYpzRkk
> Mzr4aCbk&m=3DdvtRkwC273FmalEZE_KonLRWrIVWLSWfG61NWTWG5LI&s=3Dh-
> TMyLlEdAwew-u52q4dgWBUMgm0ys-xKzvOO86e1Lw&e=3D  next
> > config: powerpc-allyesconfig (attached as .config)
> > compiler: powerpc64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=3D1
> > build):
> >          wget https://urldefense.proofpoint.com/v2/url?u=3Dhttps-
> 3A__raw.githubusercontent.com_intel_lkp-
> 2Dtests_master_sbin_make.cross&d=3DDwIC-
> g&c=3DnKjWec2b6R0mOyPaz7xtfQ&r=3DTjMsEFPc7dirkF6u2D3eSIS0cA8FeYpzRkk
> Mzr4aCbk&m=3DdvtRkwC273FmalEZE_KonLRWrIVWLSWfG61NWTWG5LI&s=3Daz
> QcL0MQmPpr9UfvyBSSdQiu1UbjJgFrzNJOtcZ_--E&e=3D  -O ~/bin/make.cross
> >          chmod +x ~/bin/make.cross
> >          # save the attached .config to linux build tree
> >          COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0
> > make.cross ARCH=3Dpowerpc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> >     powerpc64-linux-ld: lib/pci_iomap.o: in function `__crc_pci_iounmap=
':
> >>> (.rodata+0x10): multiple definition of `__crc_pci_iounmap';
> >>> lib/iomap.o:(.rodata+0x68): first defined here
> EXPORT_SYMBOL(pci_iounmap) in lib/iomap.c need be removed.
I really don't think that is the way to fix this. I have also seen your oth=
er patch=20
in which iomap being moved out of lib/iomap.c to header file.

There was a reason for moving iomap and its variants to a lib since most of
the arch's implementation of map was similar. Whereas the unmap had multipl=
e=20
implementation per arch's. So, the lib/iomap never implemented the generic =
unmap.

I see either of the following solution.
a. Have an arm64 specific implementation for the unmap function.
Or
b. something on the lines of v2[1], which accommodates all the arch's but h=
as the #ifdef
for which Bjorn raised his concerns.

Bjorn, any comments?

Regards
-George

[1] - https://lkml.org/lkml/2020/8/20/28