Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1950393pxk; Tue, 1 Sep 2020 11:37:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDtN2LSm/HOPJE0rYvA5bfRx6ZJB+zjG6n52HgHY/rYDLfncN0ixZryNd4BHtzktU1Jjhg X-Received: by 2002:a50:8523:: with SMTP id 32mr3203555edr.282.1598985468415; Tue, 01 Sep 2020 11:37:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598985468; cv=none; d=google.com; s=arc-20160816; b=eUL2zQxOh/kV4ADJBcz3nZ7j6dysuvC9cKG1pr7x+PQKHjhlTG+7T4BOsDEd3bZk8F 63HCiIauKfVBnM+qfcqFiEYZBhV8Or37hidKWW7AG7Ih+uNZ2laRhsomVTL322mkbsFU CWOaBnJA5fRoWHEM5BlRK23xAsbmp8tNpRDCJ4OZOWSrDor5gjwu3njCLx98ZI1ru2v4 A2AOJN8CPzoa3//iWLj3At3+Y0mMr2l6WSf0SuUgPALbUXLiXrOybGDi9iQ7EHNxWTGU aqzaQ9luJ9Y85KWBKXyNbkzqMntKiHxRIPjSe7jaKnIosy7K5Sf4X6B79QcJv2rXc7Q6 hyHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=mf0nPLzREel89G4QcgzazefADTL8LTtTG7M5Y1zLEZk=; b=sZf3ZaL56Or+Y+KHh6OF/MYT+WLoXbMx5wPTfUnmr+vC+e2QGUPKp9PIPJI43mBhGP hSaCbC/jhkvfML+cAwjhjlovuJQbPV5UgybhbhBR2m36rGW2QNXvCtC3cbT4sH3oHVnv pmn663JAgusM/qxJGhrG1XJ/h9cxeAu55ulFVrADNrae8rpdY/cDiM/lF4jz0oP3kPeG eKEyxi2D8AFzxURKZ2G0Qyx0R3lUYs+1sCuvEQg07FgmSr6BrwRZjlnRxiEGfQAuqkBG f/NhjAKLLVvbdfU6pWrxEOA0mC2UooHLpJ223YjMinmj6B1g5dDyRiEEl6P79YCqh9Wf C8wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si1077938edr.111.2020.09.01.11.37.24; Tue, 01 Sep 2020 11:37:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729956AbgIASfJ (ORCPT + 99 others); Tue, 1 Sep 2020 14:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbgIASfJ (ORCPT ); Tue, 1 Sep 2020 14:35:09 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80420C061244; Tue, 1 Sep 2020 11:35:09 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BFE3B1362DF13; Tue, 1 Sep 2020 11:18:18 -0700 (PDT) Date: Tue, 01 Sep 2020 11:34:45 -0700 (PDT) Message-Id: <20200901.113445.1511774749622784918.davem@davemloft.net> To: linyunsheng@huawei.com Cc: eric.dumazet@gmail.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, john.fastabend@gmail.com Subject: Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc From: David Miller In-Reply-To: <2b60e7fd-a86a-89ab-2759-e7a83e0e28cd@huawei.com> References: <1598921718-79505-1-git-send-email-linyunsheng@huawei.com> <2d93706f-3ba6-128b-738a-b063216eba6d@gmail.com> <2b60e7fd-a86a-89ab-2759-e7a83e0e28cd@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Tue, 01 Sep 2020 11:18:19 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yunsheng Lin Date: Tue, 1 Sep 2020 15:27:44 +0800 > On 2020/9/1 14:48, Eric Dumazet wrote: >> We request Fixes: tag for fixes in networking land. > > ok. > > Fixes: 6b3ba9146fe6 ("net: sched: allow qdiscs to handle locking") You should repost the patch with the Fixes: tag in order to add it, you can't just mention it in this thread. And the patch has to change anyways as you were also given other feedback from Eric to address as well. Thank you.