Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1991343pxk; Tue, 1 Sep 2020 12:45:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw9tsuEoae8evW9Pzzx/2OZivjo3MDsXsJPyPigmkshWwPVQ4U6Zwm07Yysns3zXlEjSbGQ X-Received: by 2002:a50:8523:: with SMTP id 32mr3495807edr.282.1598989521489; Tue, 01 Sep 2020 12:45:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598989521; cv=none; d=google.com; s=arc-20160816; b=FAYA3lveSBGGfdE5P/flst+XKt8tlpHptf3VyB3Yz+q1uUvJbR1WryZLcSXD3bVXqx tphpuZL55rqAzuRFtbQG93d5vidUAXdi1bwGvPwc13AirBeHo1YIluc8zMXH3Mq8vS3w LFAMUqt5oFMSx+EZGmrijTwe12iV7aF2AyE0Y+ABuU1e6oLudJMNRgF5LveTQTQlNQRM cAN68qtTOQNhVkYpKzQ/7o8OGArZUY30tLfavydpBFwClsWL5bE/Vu0bylF4wpGGAJtd DFcv8YKVyB9GIU7VYzT4F6tzMcBM/ThMNziX+xJgndtVX8ZMw87meFDd/O4FOUgmvo0n 0Izw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:content-id:mime-version :subject:cc:to:references:in-reply-to:from:organization :dkim-signature; bh=k7XoFpfF3zK9F/hjkpwRp6hPdDVo06E2ZLhjn5fGMkY=; b=Vxik7wZpAyOo7QuOQbQkpfGeubC3QoQoUNOOtjkR9PoHvAt3aWb7zA+Y6OgoHRbYHR 7E8E2or7FDY1GIROjRuQdqhD7USRw2k/iGhvCm7EdEIi5ADJIg8x5kXXZCU4ePLHmqha FTC8PjjPriGysGUm1MeTxV/oxu+1QP5oZXaMIx9fXcfl6jYcgVsuYb/EJbYpcvRfp8x1 af/giMIxRO2BXa64yUFrnPoyPc9p8JlJ5WCNZFs074XCV6Iwmn+vZEDVfFQa6aVEN0FR b4+tne+PxeXGw9HrJFBrLs2hoaTvkyLbPVufDyzoayjfgADbIUyLGNOQZZSvumoImDPL Qjpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SquMm66G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si1213500ejc.182.2020.09.01.12.44.57; Tue, 01 Sep 2020 12:45:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SquMm66G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727894AbgIATkd (ORCPT + 99 others); Tue, 1 Sep 2020 15:40:33 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:52530 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726936AbgIATkb (ORCPT ); Tue, 1 Sep 2020 15:40:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598989230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k7XoFpfF3zK9F/hjkpwRp6hPdDVo06E2ZLhjn5fGMkY=; b=SquMm66GtVMqAZCMPI4sebTtMTxRrlnbINNeaRmC+aR/JDEwR+3Um79+dqXSVPAo0XRT7v a3zfqZxigK4RtkOYfN3TnUtOHWgMlSGrvbIczt7RDUf6pYUYZPMyEdA1UjuuWoNaWR8Lwh TpwKAxflBm4OyIgywWCZKQ86ESE6gWg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-501-NBhsF6_WMFSlQ5EdgLgVgQ-1; Tue, 01 Sep 2020 15:40:29 -0400 X-MC-Unique: NBhsF6_WMFSlQ5EdgLgVgQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1B7A18B9EB6; Tue, 1 Sep 2020 19:40:27 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-113-231.rdu2.redhat.com [10.10.113.231]) by smtp.corp.redhat.com (Postfix) with ESMTP id A21D05C1C4; Tue, 1 Sep 2020 19:40:26 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20200901164827.GQ14765@casper.infradead.org> References: <20200901164827.GQ14765@casper.infradead.org> <159897769535.405783.17587409235571100774.stgit@warthog.procyon.org.uk> To: Matthew Wilcox Cc: dhowells@redhat.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/7] mm: Make more use of readahead_control MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <423218.1598989225.1@warthog.procyon.org.uk> Date: Tue, 01 Sep 2020 20:40:25 +0100 Message-ID: <423219.1598989225@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox wrote: > > Also there's an apparent minor bug in khugepaged.c that I've included a > > patch for: page_cache_sync_readahead() looks to be given the wrong size in > > collapse_file(). > > This needs to go in as an independent fix. But you didn't actually cc Song. Bah. I forgot to pass --auto to stgit. No matter, he saw it anyway. David