Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Sep 2020 22:09:12 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     "Jin, Yao" <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v4 1/7] perf util: Create streams
Message-ID: <20200901200912.GD470123@krava>
References: <20200824233513.16930-1-yao.jin@linux.intel.com>
 <20200824233513.16930-2-yao.jin@linux.intel.com>
 <20200831135609.GE406859@krava>
 <4cef1f08-e1c1-3227-24f2-be3108ea4d99@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cef1f08-e1c1-3227-24f2-be3108ea4d99@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Sep 01, 2020 at 10:26:25AM +0800, Jin, Yao wrote:
> Hi Jiri,
> 
> On 8/31/2020 9:56 PM, Jiri Olsa wrote:
> > On Tue, Aug 25, 2020 at 07:35:07AM +0800, Jin Yao wrote:
> > 
> > SNIP
> > 
> > > +						  int nr_streams_max,
> > > +						  enum stream_type type)
> > > +{
> > > +	struct evsel_streams *es;
> > > +	int nr_evsel = evlist->core.nr_entries, ret = -1;
> > > +
> > > +	es = create_evsel_streams(nr_evsel, nr_streams_max);
> > > +	if (!es)
> > > +		return NULL;
> > > +
> > > +	if (type == STREAM_CALLCHAIN)
> > > +		ret = evlist_init_callchain_streams(evlist, es, nr_evsel);
> > > +
> > > +	if (ret) {
> > > +		free_evsel_streams(es, nr_evsel);
> > > +		return NULL;
> > > +	}
> > > +
> > > +	return es;
> > > +}
> > > diff --git a/tools/perf/util/stream.h b/tools/perf/util/stream.h
> > > new file mode 100644
> > > index 000000000000..a8a0172b4d13
> > > --- /dev/null
> > > +++ b/tools/perf/util/stream.h
> > > @@ -0,0 +1,30 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> > > +#ifndef __PERF_STREAM_H
> > > +#define __PERF_STREAM_H
> > > +
> > > +#include "callchain.h"
> > > +
> > > +enum stream_type {
> > > +	STREAM_NONE = 0,
> > > +	STREAM_CALLCHAIN
> > 
> > do you plan to add more types?
> > 
> > jirka
> > 
> 
> Thanks for looking at this patch series.
> 
> So far, no more types in plan. :)

I was wondering what's the enum for then, it could
be hardcoded and ease up the code maybe? but it's
jus a thought, I don't follow the change deeply

jirka